Sign upLogin

pinpie/pinpie

View on GitHub
Star
src/URL.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method findFile has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function findFile($url) {
        $this->findPageFileRecur++;
        if ($this->findPageFileRecur > $this->pinpie->conf->pinpie['route to parent']) {
            return false;
        }
Severity: Minor
Found in src/URL.php - About 1 hr to fix

    Function findFile has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function findFile($url) {
        $this->findPageFileRecur++;
        if ($this->findPageFileRecur > $this->pinpie->conf->pinpie['route to parent']) {
            return false;
        }
    Severity: Minor
    Found in src/URL.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function parseUrl has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function parseUrl() {
        $this->parsed = parse_url($this->url);
        if (isset($this->parsed['scheme']))
            $this->scheme = $this->parsed['scheme'];
        if (isset($this->parsed['host']))
    Severity: Minor
    Found in src/URL.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                return $this->findFile($url);
    Severity: Major
    Found in src/URL.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return false;
      Severity: Major
      Found in src/URL.php - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status