Sign upLogin

piobyte/flamingo

View on GitHub
Star
packages/flamingo/targets/bench/suites/convert-local.ts

Summary

Maintainability
B
5 hrs
Test Coverage

Function exports has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function (suiteConfig: any) {
  return function (suiteName: string, description: string, filePath: string) {
    let prom: Promise<any> = Promise.resolve();

    function streamFunction(deferred: Deferred) {
Severity: Major
Found in packages/flamingo/targets/bench/suites/convert-local.ts - About 2 hrs to fix

    Function convertLocal has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function convertLocal(profileName: string) {
      return new Promise(function (resolve) {
        const gmOptions = { DEFAULT_MIME: "image/png" };
        const gmRequest = { headers: {}, query: { processor: "gm" } };
        const vipsOptions = { DEFAULT_MIME: "image/png" };
    Severity: Minor
    Found in packages/flamingo/targets/bench/suites/convert-local.ts - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              new Benchmark.Suite(description)
          .add("GM", {
            defer: true,
            fn: function (deferred: Deferred) {
              suiteConfig.profiles[profileName](gmRequest, gmOptions).then(
      Severity: Minor
      Found in packages/flamingo/targets/bench/suites/convert-local.ts and 1 other location - About 55 mins to fix
      packages/flamingo/targets/bench/suites/convert-local.ts on lines 46..62

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          suiteConfig.convertProfiles.forEach(function (name: string) {
      prom = prom.then(function () {
        return convertLocal(name);
      });
    });
      Severity: Minor
      Found in packages/flamingo/targets/bench/suites/convert-local.ts and 1 other location - About 50 mins to fix
      packages/flamingo/targets/bench/suites/convert-remote.ts on lines 157..161

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status