Sign upLogin

piotrkowalczuk/mnemosyne

View on GitHub
Star

Showing 37 of 37 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    if node, ok := smg.cluster.GetOther(req.AccessToken); ok {
        if cluster.IsInternalRequest(ctx) {
            return nil, status.Errorf(codes.FailedPrecondition,
                "it should be final destination of get request (%s), but found another node for it: %s",
                req.GetAccessToken(),
Severity: Major
Found in mnemosyned/session_manager_get.go and 2 other locations - About 1 hr to fix
mnemosyned/session_manager_abandon.go on lines 33..43
mnemosyned/session_manager_exists.go on lines 31..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 131.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    if node, ok := sme.cluster.GetOther(req.AccessToken); ok {
        if cluster.IsInternalRequest(ctx) {
            return nil, status.Errorf(codes.FailedPrecondition,
                "it should be final destination of exists request (%s), but found another node for it: %s",
                req.GetAccessToken(),
Severity: Major
Found in mnemosyned/session_manager_exists.go and 2 other locations - About 1 hr to fix
mnemosyned/session_manager_abandon.go on lines 33..43
mnemosyned/session_manager_get.go on lines 33..43

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 131.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    if node, ok := sma.cluster.GetOther(req.AccessToken); ok {
        if cluster.IsInternalRequest(ctx) {
            return nil, status.Errorf(codes.FailedPrecondition,
                "it should be final destination of abandon request (%s), but found another node for it: %s",
                req.GetAccessToken(),
Severity: Major
Found in mnemosyned/session_manager_abandon.go and 2 other locations - About 1 hr to fix
mnemosyned/session_manager_exists.go on lines 31..41
mnemosyned/session_manager_get.go on lines 33..43

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 131.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid deeply nested control flow statements.
Open

                            switch pqerr.Code {
                            case pq.ErrorCode("57014"):
                                code = codes.Canceled
                            }
Severity: Major
Found in mnemosyned/middleware.go - About 45 mins to fix

    exported type Context should have comment or be unexported
    Open

    type Context struct {
    Severity: Minor
    Found in internal/service/logger/logger.go by golint

    exported var Timeout should have comment or be unexported
    Open

    var Timeout = errors.New("postgres connection timeout")
    Severity: Minor
    Found in internal/service/postgres/postgres.go by golint

    exported function TestStorageStart should have comment or be unexported
    Open

    func TestStorageStart(t *testing.T, s Storage) {
    Severity: Minor
    Found in internal/storage/storage_test_suite.go by golint

    exported type Cache should have comment or be unexported
    Open

    type Cache struct {
    Severity: Minor
    Found in internal/cache/cache.go by golint

    exported type Opts should have comment or be unexported
    Open

    type Opts struct {
    Severity: Minor
    Found in internal/service/logger/logger.go by golint

    exported type Encoder should have comment or be unexported
    Open

    type Encoder struct {
    Severity: Minor
    Found in internal/service/logger/logger.go by golint

    exported function TestStorageList should have comment or be unexported
    Open

    func TestStorageList(t *testing.T, s Storage) {
    Severity: Minor
    Found in internal/storage/storage_test_suite.go by golint

    exported function TestStorageExists should have comment or be unexported
    Open

    func TestStorageExists(t *testing.T, s Storage) {
    Severity: Minor
    Found in internal/storage/storage_test_suite.go by golint

    exported function TestStorageSetValue should have comment or be unexported
    Open

    func TestStorageSetValue(t *testing.T, s Storage) {
    Severity: Minor
    Found in internal/storage/storage_test_suite.go by golint

    2: cannot find package "github.com/piotrkowalczuk/mnemosyne/internal/storage" in any of:
    Open

        "github.com/piotrkowalczuk/mnemosyne/internal/storage"
    Severity: Minor
    Found in cmd/mnemosyned/config.go by govet

    exported function TestStorageGet should have comment or be unexported
    Open

    func TestStorageGet(t *testing.T, s Storage) {
    Severity: Minor
    Found in internal/storage/storage_test_suite.go by golint

    exported function TestStorageListBetween should have comment or be unexported
    Open

    func TestStorageListBetween(t *testing.T, s Storage) {
    Severity: Minor
    Found in internal/storage/storage_test_suite.go by golint

    exported function New should have comment or be unexported
    Open

    func New(ttl time.Duration, namespace string) *Cache {
    Severity: Minor
    Found in internal/cache/cache.go by golint

    exported type Opts should have comment or be unexported
    Open

    type Opts struct {
    Severity: Minor
    Found in internal/service/postgres/postgres.go by golint

    exported function Init should have comment or be unexported
    Open

    func Init(s Storage, isTest bool) (Storage, error) {
    Severity: Minor
    Found in internal/storage/storage.go by golint

    exported type Storage should have comment or be unexported
    Open

    type Storage struct {
    Severity: Minor
    Found in internal/storage/postgres/storage.go by golint
    Severity
    Category
    Status
    Source
    Language