piotrmurach/coinpare

View on GitHub

Showing 14 of 14 total issues

File holdings.rb has 298 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require "toml"
require "pastel"
require "tty-config"
require "tty-prompt"
require "tty-spinner"
Severity: Minor
Found in lib/coinpare/commands/holdings.rb - About 3 hrs to fix

    Method execute has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

          def execute(input: $stdin, output: $stdout)
            config_saved = config.exist?
            if config_saved && @options["edit"]
              editor.open(config.source_file)
              return
    Severity: Minor
    Found in lib/coinpare/commands/holdings.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method execute has 65 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def execute(input: $stdin, output: $stdout)
            config_saved = config.exist?
            if config_saved && @options["edit"]
              editor.open(config.source_file)
              return
    Severity: Major
    Found in lib/coinpare/commands/holdings.rb - About 2 hrs to fix

      Method setup_table has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def setup_table(raw_data, display_data)
              base = @options.fetch("base", config.fetch("settings", "base")).upcase
              total_buy = 0
              total = 0
              to_symbol = nil
      Severity: Minor
      Found in lib/coinpare/commands/holdings.rb - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                pager = TTY::Pager.new(output: output)
                @spinner.auto_spin
        
                if @options["watch"]
                  output.print cursor.hide
        Severity: Major
        Found in lib/coinpare/commands/coins.rb and 1 other location - About 1 hr to fix
        lib/coinpare/commands/markets.rb on lines 25..41

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 65.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                pager = TTY::Pager.new(output: output)
                @spinner.auto_spin
        
                if @options["watch"]
                  output.print cursor.hide
        Severity: Major
        Found in lib/coinpare/commands/markets.rb and 1 other location - About 1 hr to fix
        lib/coinpare/commands/coins.rb on lines 25..41

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 65.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method setup_table has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def setup_table(raw_data, display_data)
                table = TTY::Table.new(header: [
                  { value: "Coin", alignment: :left },
                  "Price",
                  "Chg. 24H",
        Severity: Minor
        Found in lib/coinpare/commands/coins.rb - About 1 hr to fix

          Method create_pie_charts has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def create_pie_charts(raw_data, display_data)
                  colors = %i[yellow blue green cyan magenta red]
                  radius = @options["pie"].to_i > 0 ? @options["pie"].to_i : DEFAULT_PIE_RADIUS
                  base   = @options.fetch("base", config.fetch("settings", "base")).upcase
                  to_symbol = nil
          Severity: Minor
          Found in lib/coinpare/commands/holdings.rb - About 1 hr to fix

            Method setup_portfolio has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  def setup_portfolio(input, output)
                    output.print "\nCurrently you have no investments setup...\n" \
                                 "Let's change that and create your altfolio!\n\n"
            
                    prompt = create_prompt(input, output)
            Severity: Minor
            Found in lib/coinpare/commands/holdings.rb - About 1 hr to fix

              Method display_coins has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                    def display_coins(output, names, overridden_settings)
                      response = Fetcher.fetch_prices(names.join(","),
                                                      overridden_settings["base"].upcase,
                                                      overridden_settings)
                      return unless response
              Severity: Minor
              Found in lib/coinpare/commands/holdings.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  def fetch_daily_hist(from_symbol, to_symbol, options)
                    url = ["#{API_URL}histoday"]
                    url << "?fsym=#{from_symbol}&tsym=#{to_symbol}"
                    url << "&limit=#{options['top']}" if options["top"]
                    url << "&aggregate=7"
              Severity: Minor
              Found in lib/coinpare/fetcher.rb and 1 other location - About 30 mins to fix
              lib/coinpare/fetcher.rb on lines 55..61

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 33.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  def fetch_prices(from_symbols, to_symbols, options)
                    url = ["#{API_URL}pricemultifull"]
                    url << "?fsyms=#{from_symbols}&tsyms=#{to_symbols}"
                    url << "&e=#{options['exchange']}" if options["exchange"]
                    url << "&tryConversion=true"
              Severity: Minor
              Found in lib/coinpare/fetcher.rb and 1 other location - About 30 mins to fix
              lib/coinpare/fetcher.rb on lines 37..43

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 33.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method execute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                    def execute(input: $stdin, output: $stdout)
                      pager = TTY::Pager.new(output: output)
                      @spinner.auto_spin
              
                      if @options["watch"]
              Severity: Minor
              Found in lib/coinpare/commands/markets.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method execute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                    def execute(output: $stdout)
                      pager = TTY::Pager.new(output: output)
                      @spinner.auto_spin
              
                      if @options["watch"]
              Severity: Minor
              Found in lib/coinpare/commands/coins.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language