Sign upLogin

piotrmurach/github_cli

View on GitHub
Star
lib/github_cli/apis/label.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method delete has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def self.delete(user, repo, name, params, options)
Severity: Minor
Found in lib/github_cli/apis/label.rb - About 35 mins to fix

    Method update has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def self.update(user, repo, name, params, options)
    Severity: Minor
    Found in lib/github_cli/apis/label.rb - About 35 mins to fix

      Method get has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def self.get(user, repo, name, params, options)
      Severity: Minor
      Found in lib/github_cli/apis/label.rb - About 35 mins to fix

        Method remove has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def self.remove(user, repo, issue_id, params, options)
        Severity: Minor
        Found in lib/github_cli/apis/label.rb - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def self.add(user, repo, issue_id, *args)
      options, params = args.pop, args.pop
      output options do
        github_api(options).issues.labels.add user, repo, issue_id, args.flatten, params
          Severity: Minor
          Found in lib/github_cli/apis/label.rb and 1 other location - About 15 mins to fix
          lib/github_cli/apis/label.rb on lines 52..55

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 26.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def self.replace(user, repo, issue_id, *args)
      options, params = args.pop, args.pop
      output options do
        github_api(options).issues.labels.replace user, repo, issue_id, args.flatten, params
          Severity: Minor
          Found in lib/github_cli/apis/label.rb and 1 other location - About 15 mins to fix
          lib/github_cli/apis/label.rb on lines 39..42

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 26.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status