Sign upLogin

piotrmurach/github_cli

View on GitHub
Star
lib/github_cli/commands/repositories.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method create has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

      def create(args)
        global_options = options.dup
        params = options[:params].dup
        org, params["name"] = Arguments.new(args).parse
        params["org"]                = org if org
Severity: Minor
Found in lib/github_cli/commands/repositories.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method edit has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

      def edit(user, repo, name)
        global_options = options.dup
        params = options[:params].dup
        params["name"] = name
        params["description"]        = options["desc"] if options.key?("desc")
Severity: Minor
Found in lib/github_cli/commands/repositories.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method list has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def list
        global_options = options.dup
        params = options[:params].dup
        params["org"]   = options[:org]   if options.key?("org")
        params["user"]  = options[:user]  if options.key?("user")
Severity: Minor
Found in lib/github_cli/commands/repositories.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      def list
        global_options = options.dup
        params = options[:params].dup
        params["org"]   = options[:org]   if options.key?("org")
        params["user"]  = options[:user]  if options.key?("user")
Severity: Major
Found in lib/github_cli/commands/repositories.rb and 1 other location - About 2 hrs to fix
lib/github_cli/commands/authorizations.rb on lines 60..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 82.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 31 locations. Consider refactoring.
Open

      def branch(user, repo, name)
        global_options = options.dup
        params = options[:params].dup
        Util.hash_without!(global_options, params.keys + ["params"])
        Repository.branch user, repo, name, params, global_options
Severity: Major
Found in lib/github_cli/commands/repositories.rb and 30 other locations - About 15 mins to fix
lib/github_cli/commands/assignees.rb on lines 25..29
lib/github_cli/commands/blobs.rb on lines 14..19
lib/github_cli/commands/collaborators.rb on lines 22..26
lib/github_cli/commands/collaborators.rb on lines 30..34
lib/github_cli/commands/collaborators.rb on lines 38..42
lib/github_cli/commands/commits.rb on lines 14..18
lib/github_cli/commands/downloads.rb on lines 22..26
lib/github_cli/commands/downloads.rb on lines 80..84
lib/github_cli/commands/issues.rb on lines 88..92
lib/github_cli/commands/keys.rb on lines 22..26
lib/github_cli/commands/keys.rb on lines 50..54
lib/github_cli/commands/keys.rb on lines 58..62
lib/github_cli/commands/labels.rb on lines 35..39
lib/github_cli/commands/labels.rb on lines 88..92
lib/github_cli/commands/milestones.rb on lines 38..42
lib/github_cli/commands/milestones.rb on lines 104..108
lib/github_cli/commands/pull_requests.rb on lines 32..36
lib/github_cli/commands/pull_requests.rb on lines 92..96
lib/github_cli/commands/pull_requests.rb on lines 100..104
lib/github_cli/commands/pull_requests.rb on lines 108..112
lib/github_cli/commands/pull_requests.rb on lines 116..120
lib/github_cli/commands/references.rb on lines 26..30
lib/github_cli/commands/references.rb on lines 74..78
lib/github_cli/commands/releases.rb on lines 22..26
lib/github_cli/commands/releases.rb on lines 106..110
lib/github_cli/commands/statuses.rb on lines 14..18
lib/github_cli/commands/tags.rb on lines 16..20
lib/github_cli/commands/teams.rb on lines 163..167
lib/github_cli/commands/teams.rb on lines 176..180
lib/github_cli/commands/teams.rb on lines 189..193

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status