piotrmurach/rspec-benchmark

View on GitHub

Showing 4 of 4 total issues

Class Matcher has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

      class Matcher
        def initialize(expected, comparison_type, **options)
          check_comparison(comparison_type)
          @expected = expected
          @comparison_type = comparison_type
Severity: Minor
Found in lib/rspec/benchmark/comparison_matcher.rb - About 2 hrs to fix

    Method matches? has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def matches?(block)
              @block = block
              alloc_stats = @bench.trace(&block)
              @actual = nil
              @actual_retained = nil
    Severity: Minor
    Found in lib/rspec/benchmark/allocation_matcher.rb - About 1 hr to fix

      Method pluralize_objects has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

              def pluralize_objects(value)
                if value.respond_to?(:to_hash)
                  if value.keys.size == 1 && value.values.reduce(&:+) == 1
                    "object"
                  else
      Severity: Minor
      Found in lib/rspec/benchmark/allocation_matcher.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method matches? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

              def matches?(block)
                @block = block
                alloc_stats = @bench.trace(&block)
                @actual = nil
                @actual_retained = nil
      Severity: Minor
      Found in lib/rspec/benchmark/allocation_matcher.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language