Sign upLogin

piotrmurach/slideck

View on GitHub
Star

Showing 3 of 3 total issues

Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def initialize(reader, renderer, tracker, screen, output, &reloader)
Severity: Minor
Found in lib/slideck/presenter.rb - About 45 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def find_top_row(alignment, margin, num_of_lines)
      case alignment
      when "top"
        margin.top
      when "center"
    Severity: Minor
    Found in lib/slideck/renderer.rb and 1 other location - About 25 mins to fix
    lib/slideck/renderer.rb on lines 237..244

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 31.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def find_left_column(alignment, margin, content_length)
      case alignment
      when "left"
        margin.left
      when "center"
    Severity: Minor
    Found in lib/slideck/renderer.rb and 1 other location - About 25 mins to fix
    lib/slideck/renderer.rb on lines 260..267

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 31.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Severity
    Category
    Status
    Source
    Language