Sign upLogin

piotrmurach/tty-prompt

View on GitHub
Star

Showing 49 of 49 total issues

Class List has 43 methods (exceeds 20 allowed). Consider refactoring.
Open

    class List
      # Allowed keys for filter, along with backspace and canc.
      FILTER_KEYS_MATCHER = /\A([[:alnum:]]|[[:punct:]])\Z/.freeze

      # Checks type of default parameter to be integer
Severity: Minor
Found in lib/tty/prompt/list.rb - About 5 hrs to fix

    File list.rb has 344 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require "English"

require_relative "choices"
require_relative "paginator"
require_relative "block_paginator"
    Severity: Minor
    Found in lib/tty/prompt/list.rb - About 4 hrs to fix

      Class EnumList has 33 methods (exceeds 20 allowed). Consider refactoring.
      Open

          class EnumList
      PAGE_HELP = "(Press tab/right or left to reveal more choices)"

      # Checks type of default parameter to be integer
      INTEGER_MATCHER = /\A[-+]?\d+\Z/.freeze
      Severity: Minor
      Found in lib/tty/prompt/enum_list.rb - About 4 hrs to fix

        Class Prompt has 28 methods (exceeds 20 allowed). Consider refactoring.
        Open

          class Prompt
    extend Forwardable

    # @api private
    attr_reader :input
        Severity: Minor
        Found in lib/tty/prompt.rb - About 3 hrs to fix

          Class Question has 28 methods (exceeds 20 allowed). Consider refactoring.
          Open

              class Question
      include Checks

      UndefinedSetting = Class.new do
        def to_s
          Severity: Minor
          Found in lib/tty/prompt/question.rb - About 3 hrs to fix

            Class Expander has 25 methods (exceeds 20 allowed). Consider refactoring.
            Open

                class Expander
      HELP_CHOICE = {
        key: "h",
        name: "print help",
        value: :help
            Severity: Minor
            Found in lib/tty/prompt/expander.rb - About 2 hrs to fix

              Class Slider has 25 methods (exceeds 20 allowed). Consider refactoring.
              Open

                  class Slider
      HELP = "(Use %s arrow keys, press Enter to select)"

      FORMAT = ":slider %s"
              Severity: Minor
              Found in lib/tty/prompt/slider.rb - About 2 hrs to fix

                Method paginate has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
                Open

                      def paginate(list, active, per_page = nil, &block)
        current_index = active - 1
        default_size = (list.size <= DEFAULT_PAGE_SIZE ? list.size : DEFAULT_PAGE_SIZE)
        @per_page = @per_page || per_page || default_size
        check_page_size!
                Severity: Minor
                Found in lib/tty/prompt/paginator.rb - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method render_header has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
                Open

                      def render_header
        instructions = @prompt.decorate(help, @help_color)
        minmax_suffix = @min || @max ? minmax_help : ""
        print_selected = @selected.size.nonzero? && @echo
                Severity: Minor
                Found in lib/tty/prompt/multi_list.rb - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method render_menu has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
                Open

                      def render_menu
        output = []

        sync_paginators if @paging_changed
        paginator.paginate(choices, @active, @per_page) do |choice, index|
                Severity: Minor
                Found in lib/tty/prompt/multi_list.rb - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method paginate has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
                Open

                      def paginate(list, active, per_page = nil, &block)
        default_size = (list.size <= DEFAULT_PAGE_SIZE ? list.size : DEFAULT_PAGE_SIZE)
        @per_page = @per_page || per_page || default_size

        check_page_size!
                Severity: Minor
                Found in lib/tty/prompt/block_paginator.rb - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method render_menu has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                Open

                      def render_menu
        output = []

        sync_paginators if @paging_changed
        paginator.paginate(choices, @active, @per_page) do |choice, index|
                Severity: Minor
                Found in lib/tty/prompt/list.rb - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method distance has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                Open

                      def distance(first, second)
        distances = []
        rows      = first.to_s.length
        cols      = second.to_s.length
                Severity: Minor
                Found in lib/tty/prompt/distance.rb - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method paginate has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                      def paginate(list, active, per_page = nil, &block)
        current_index = active - 1
        default_size = (list.size <= DEFAULT_PAGE_SIZE ? list.size : DEFAULT_PAGE_SIZE)
        @per_page = @per_page || per_page || default_size
        check_page_size!
                Severity: Minor
                Found in lib/tty/prompt/paginator.rb - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                        WIN_KEYS = {
        tick: "√",
        cross: "x",
        star: "*",
        square: "[█]",
                  Severity: Major
                  Found in lib/tty/prompt/symbols.rb and 1 other location - About 1 hr to fix
                  lib/tty/prompt/symbols.rb on lines 9..39

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 61.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                        KEYS = {
        tick: "✓",
        cross: "✘",
        star: "★",
        square: "◼",
                  Severity: Major
                  Found in lib/tty/prompt/symbols.rb and 1 other location - About 1 hr to fix
                  lib/tty/prompt/symbols.rb on lines 41..71

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 61.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method paginate has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                        def paginate(list, active, per_page = nil, &block)
        default_size = (list.size <= DEFAULT_PAGE_SIZE ? list.size : DEFAULT_PAGE_SIZE)
        @per_page = @per_page || per_page || default_size

        check_page_size!
                  Severity: Minor
                  Found in lib/tty/prompt/block_paginator.rb - About 1 hr to fix

                    Method validate_choices has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                    Open

                          def validate_choices
        errors = []
        keys = []
        @choices.each do |choice|
          if choice.key.nil?
                    Severity: Minor
                    Found in lib/tty/prompt/expander.rb - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method keyright has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                    Open

                          def keyright(*)
        choices_size = choices.size
        if (@active + page_size) <= choices_size
          searchable = ((@active + page_size)..choices_size)
          @active = search_choice_in(searchable)
                    Severity: Minor
                    Found in lib/tty/prompt/list.rb - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method distance has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                          def distance(first, second)
        distances = []
        rows      = first.to_s.length
        cols      = second.to_s.length
                    Severity: Minor
                    Found in lib/tty/prompt/distance.rb - About 1 hr to fix
                      Severity
                      Category
                      Status
                      Source
                      Language