Sign upLogin

piotrmurach/tty-which

View on GitHub
Star

Showing 2 of 2 total issues

Method which has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    def which(cmd, paths: search_paths)
      if file_with_path?(cmd)
        return cmd if executable_file?(cmd)

        extensions.each do |ext|
Severity: Minor
Found in lib/tty/which.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

          return ::File.absolute_path(exe) if executable_file?(exe)
Severity: Major
Found in lib/tty/which.rb - About 30 mins to fix
    Severity
    Category
    Status
    Source
    Language