Sign upLogin

piotrpolak/pepiscms

View on GitHub
Star
pepiscms/application/classes/DefaultFormRenderer.php

Summary

Maintainability
C
1 day
Test Coverage

DefaultFormRenderer has 25 functions (exceeds 20 allowed). Consider refactoring.
Open

class DefaultFormRenderer extends ContainerAware implements FormRenderableInterface
{
    protected $is_js_included = false;
    protected $validation_message_prefix = false;
    protected $validation_message_suffix = false;
Severity: Minor
Found in pepiscms/application/classes/DefaultFormRenderer.php - About 2 hrs to fix

    File DefaultFormRenderer.php has 274 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

/**
 * PepisCMS
 *
    Severity: Minor
    Found in pepiscms/application/classes/DefaultFormRenderer.php - About 2 hrs to fix

      Method resolveComponent has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function resolveComponent($componentId)
    {
        /**
         * @var $registeredComponents \PiotrPolak\PepisCMS\Formbuilder\Component\ComponentInterface[]
         */
      Severity: Minor
      Found in pepiscms/application/classes/DefaultFormRenderer.php - About 1 hr to fix

        Function renderInput has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            private function renderInput($field, $value, &$object,
                                 \PiotrPolak\PepisCMS\Formbuilder\Component\ComponentInterface $component, $readOnly)
    {
        $extra_css_classes = $this->computeExtraCssClasses($field);
        Severity: Minor
        Found in pepiscms/application/classes/DefaultFormRenderer.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method computeReadOnlyComponentHtml has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            private function computeReadOnlyComponentHtml($field, $valueEscaped, $object,
          \PiotrPolak\PepisCMS\Formbuilder\Component\ComponentInterface $component, $formatting_function_for_uneditable)
        Severity: Minor
        Found in pepiscms/application/classes/DefaultFormRenderer.php - About 35 mins to fix

          Method renderInput has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              private function renderInput($field, $value, &$object,
                                 \PiotrPolak\PepisCMS\Formbuilder\Component\ComponentInterface $component, $readOnly)
          Severity: Minor
          Found in pepiscms/application/classes/DefaultFormRenderer.php - About 35 mins to fix

            Function getFormButtons has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getFormButtons()
    {
        $output = '<div class="buttons">' . "\n";
        if ($this->formbuilder->getBackLink()) {
            $output .= button_cancel($this->formbuilder->getBackLink());
            Severity: Minor
            Found in pepiscms/application/classes/DefaultFormRenderer.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status