piotrpolak/pepiscms

View on GitHub
pepiscms/application/core/PEPISCMS_Lang.php

Summary

Maintainability
C
1 day
Test Coverage

Function loadForModule has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

    public function loadForModule($langfile = '', $idiom = '', $return = false, $module_name = false)
    {
        // TODO Remove this hack
        $langfile = str_replace('.php', '', str_replace('_lang.', '', $langfile)) . '_lang.php';

Severity: Minor
Found in pepiscms/application/core/PEPISCMS_Lang.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method loadForModule has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function loadForModule($langfile = '', $idiom = '', $return = false, $module_name = false)
    {
        // TODO Remove this hack
        $langfile = str_replace('.php', '', str_replace('_lang.', '', $langfile)) . '_lang.php';

Severity: Major
Found in pepiscms/application/core/PEPISCMS_Lang.php - About 2 hrs to fix

    Function getCurrentLanguage has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getCurrentLanguage()
        {
            $CI = &get_instance();
            $idiom = false;
    
    
    Severity: Minor
    Found in pepiscms/application/core/PEPISCMS_Lang.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function line has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function line($line = '', $default_value = null)
        {
            // Changed parameter order - might be problematic
    
            if ($line == '' || !isset($this->language[$line])) {
    Severity: Minor
    Found in pepiscms/application/core/PEPISCMS_Lang.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method load has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function load($langfile, $idiom = '', $return = false, $add_suffix = true, $alt_path = '')
    Severity: Minor
    Found in pepiscms/application/core/PEPISCMS_Lang.php - About 35 mins to fix

      Avoid too many return statements within this method.
      Open

              return true;
      Severity: Major
      Found in pepiscms/application/core/PEPISCMS_Lang.php - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status