Sign upLogin

piotrpolak/pepiscms

View on GitHub
Star
pepiscms/application/helpers/mysqldump_helper.php

Summary

Maintainability
C
1 day
Test Coverage

Function mysqldump has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

    function mysqldump($db_host, $database, $db_user, $db_password, $tables = false, $dump_to_filename = false, $dump_structure = true)
    {
        if ($dump_to_filename && file_exists($dump_to_filename)) {
            return false;
        }
Severity: Minor
Found in pepiscms/application/helpers/mysqldump_helper.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method mysqldump has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function mysqldump($db_host, $database, $db_user, $db_password, $tables = false, $dump_to_filename = false, $dump_structure = true)
    {
        if ($dump_to_filename && file_exists($dump_to_filename)) {
            return false;
        }
Severity: Major
Found in pepiscms/application/helpers/mysqldump_helper.php - About 2 hrs to fix

    Method mysqldump has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        function mysqldump($db_host, $database, $db_user, $db_password, $tables = false, $dump_to_filename = false, $dump_structure = true)
    Severity: Major
    Found in pepiscms/application/helpers/mysqldump_helper.php - About 50 mins to fix

      Avoid too many return statements within this method.
      Open

              return false;
      Severity: Major
      Found in pepiscms/application/helpers/mysqldump_helper.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return $dump;
        Severity: Major
        Found in pepiscms/application/helpers/mysqldump_helper.php - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status