Sign upLogin

piotrpolak/pepiscms

View on GitHub
Star
pepiscms/application/libraries/PEPISCMS_Form_validation.php

Summary

Maintainability
A
1 hr
Test Coverage

Function valid_timestamp has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function valid_timestamp($str)
    {
        if (strlen($str) == 0) {
            return true;
        }
Severity: Minor
Found in pepiscms/application/libraries/PEPISCMS_Form_validation.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

                if ($H >= 0 && $H <= 24
                    && $i >= 0 && $i <= 60
                    && $s >= 0 && $s <= 60
                ) {
                    return true;
Severity: Major
Found in pepiscms/application/libraries/PEPISCMS_Form_validation.php - About 40 mins to fix

    There are no issues that match your filters.

    Category
    Status