piotrpolak/pepiscms

View on GitHub
pepiscms/application/libraries/PEPISCMS_Upload.php

Summary

Maintainability
B
5 hrs
Test Coverage

Function is_allowed_filetype has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public function is_allowed_filetype($ignore_mime = false)
    {
        if ($this->allowed_types === '*') {
            return true;
        }
Severity: Minor
Found in pepiscms/application/libraries/PEPISCMS_Upload.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method is_allowed_filetype has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function is_allowed_filetype($ignore_mime = false)
    {
        if ($this->allowed_types === '*') {
            return true;
        }
Severity: Minor
Found in pepiscms/application/libraries/PEPISCMS_Upload.php - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

            return false;
    Severity: Major
    Found in pepiscms/application/libraries/PEPISCMS_Upload.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return $success;
      Severity: Major
      Found in pepiscms/application/libraries/PEPISCMS_Upload.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return true;
        Severity: Major
        Found in pepiscms/application/libraries/PEPISCMS_Upload.php - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status