Sign upLogin

piotrpolak/pepiscms

View on GitHub
Star
pepiscms/application/models/Menu_model.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method getMenuFlat has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function getMenuFlat($parent_item_id = 0, $language_code = 'en', $dont_enter_item_id = false, $separator = false, &$menu = array(), $return = true, $prefix = '')
Severity: Major
Found in pepiscms/application/models/Menu_model.php - About 50 mins to fix

    Function getMenuFlat has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getMenuFlat($parent_item_id = 0, $language_code = 'en', $dont_enter_item_id = false, $separator = false, &$menu = array(), $return = true, $prefix = '')
    {
        if (!$language_code) {
            $language_code = 'en';
        }
    Severity: Minor
    Found in pepiscms/application/models/Menu_model.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function saveById has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public function saveById($id, $data)
    {
        if (!$id) {
            if (!isset($data['language_code']) || !$data['language_code']) {
                $data['language_code'] = 'en';
    Severity: Minor
    Found in pepiscms/application/models/Menu_model.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status