pivotal/LicenseFinder

View on GitHub
lib/license_finder/license/definitions.rb

Summary

Maintainability
D
1 day
Test Coverage

File definitions.rb has 450 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module LicenseFinder
  class License
    module Definitions
      extend self

Severity: Minor
Found in lib/license_finder/license/definitions.rb - About 6 hrs to fix

    Class License has 30 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class License
        module Definitions
          extend self
    
          def all
    Severity: Minor
    Found in lib/license_finder/license/definitions.rb - About 3 hrs to fix

      Method newbsd has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def newbsd
              template = Template.named('NewBSD')
              alternate_content = template.content.gsub(
                'Neither the name of <organization> nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission.',
                'The names of its contributors may not be used to endorse or promote products derived from this software without specific prior written permission.'
      Severity: Minor
      Found in lib/license_finder/license/definitions.rb - About 1 hr to fix

        Method all has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def all
                [
                  agpl3,
                  apache1_1,
                  apache2,
        Severity: Minor
        Found in lib/license_finder/license/definitions.rb - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                def apache1_1
                  License.new(
                    short_name: 'Apache1_1',
                    spdx_id: 'Apache-1.1',
                    pretty_name: 'Apache 1.1',
          Severity: Minor
          Found in lib/license_finder/license/definitions.rb and 1 other location - About 15 mins to fix
          lib/license_finder/license/definitions.rb on lines 89..108

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 26.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                def apache2
                  License.new(
                    short_name: 'Apache2',
                    spdx_id: 'Apache-2.0',
                    pretty_name: 'Apache 2.0',
          Severity: Minor
          Found in lib/license_finder/license/definitions.rb and 1 other location - About 15 mins to fix
          lib/license_finder/license/definitions.rb on lines 67..86

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 26.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status