Sign upLogin

pixelfederation/swoole-bundle

View on GitHub
Star

Showing 252 of 252 total issues

Line indented incorrectly; expected 4 spaces, found 8
Open

        private RepositoryFactory $decorated,
Severity: Minor
Found in src/Bridge/Doctrine/ServicePooledRepositoryFactory.php by phpcodesniffer

Line indented incorrectly; expected 4 spaces, found 8
Open

        private EntityManagerInterface $pooledEm
Severity: Minor
Found in src/Bridge/Doctrine/ServicePooledRepositoryFactory.php by phpcodesniffer

Line indented incorrectly; expected 4 spaces, found 8
Open

        private HttpKernelInterface $kernel,
Severity: Minor
Found in src/Bridge/Symfony/ErrorHandler/SymfonyExceptionHandler.php by phpcodesniffer

Line indented incorrectly; expected 4 spaces, found 8
Open

        private ManagerConfigurator $wrapped,
Severity: Minor
Found in src/Bridge/Doctrine/BlockingProxyFactoryOverridingManagerConfigurator.php by phpcodesniffer

Line indented incorrectly; expected 4 spaces, found 8
Open

        private ResponseProcessorInterface $responseProcessor
Severity: Minor
Found in src/Bridge/Symfony/HttpKernel/HttpKernelRequestHandler.php by phpcodesniffer

Line indented incorrectly; expected 4 spaces, found 8
Open

        private FirstTimeOnlyMutexFactory $mutexFactory
Severity: Minor
Found in src/Bridge/Doctrine/BlockingProxyFactory.php by phpcodesniffer

Line indented incorrectly; expected 4 spaces, found 8
Open

        private FirstTimeOnlyMutexFactory $mutexFactory
Severity: Minor
Found in src/Bridge/Doctrine/BlockingProxyFactoryOverridingManagerConfigurator.php by phpcodesniffer

Line indented incorrectly; expected 4 spaces, found 8
Open

        private ExceptionHandlerFactory $handlerFactory
Severity: Minor
Found in src/Bridge/Symfony/ErrorHandler/ErrorResponder.php by phpcodesniffer

Line indented incorrectly; expected 4 spaces, found 8
Open

        private ResponseProcessorInjectorInterface $processorInjector,
Severity: Minor
Found in src/Bridge/Symfony/HttpKernel/HttpKernelRequestHandler.php by phpcodesniffer

Line indented incorrectly; expected 4 spaces, found 8
Open

        private ErrorResponder $errorResponder
Severity: Minor
Found in src/Bridge/Symfony/ErrorHandler/SymfonyExceptionHandler.php by phpcodesniffer

Line indented incorrectly; expected 4 spaces, found 8
Open

        private HttpKernelInterface $kernel,
Severity: Minor
Found in src/Bridge/Symfony/ErrorHandler/ExceptionHandlerFactory.php by phpcodesniffer

Define a constant instead of duplicating this literal "requestLimit" 3 times.
Open

        return ['requestLimit' => $requestLimit] + parent::prepareRuntimeConfiguration($serverConfiguration, $input);
Severity: Critical
Found in src/Bridge/Symfony/Bundle/Command/ServerProfileCommand.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Severity
Category
Status
Source
Language