pixijs/pixi-haxe

View on GitHub
samples/src/scaletest/Main.hx

Summary

Maintainability
Test Coverage

8 is a magic number
Open

        if (_scale > 8) _scale = 8;

Checks that there are no magic numbers. By default, -1, 0, 1, and 2 are not considered to be magic numbers.

8 is a magic number
Open

        if (_scale2 > 8) _scale2 = 8;

Checks that there are no magic numbers. By default, -1, 0, 1, and 2 are not considered to be magic numbers.

24 is a magic number
Open

            _reels.width = Browser.window.innerWidth - (24 * _scale);

Checks that there are no magic numbers. By default, -1, 0, 1, and 2 are not considered to be magic numbers.

0.5 is a magic number
Open

        _bg.anchor.set(0.5);

Checks that there are no magic numbers. By default, -1, 0, 1, and 2 are not considered to be magic numbers.

320 is a magic number
Open

    var _baseSize:Int = 320;

Checks that there are no magic numbers. By default, -1, 0, 1, and 2 are not considered to be magic numbers.

8 is a magic number
Open

        if (_scale > 8) _scale = 8;

Checks that there are no magic numbers. By default, -1, 0, 1, and 2 are not considered to be magic numbers.

8 is a magic number
Open

        if (_scale2 > 8) _scale2 = 8;

Checks that there are no magic numbers. By default, -1, 0, 1, and 2 are not considered to be magic numbers.

0xF78181 is a magic number
Open

        style.fill = 0xF78181;

Checks that there are no magic numbers. By default, -1, 0, 1, and 2 are not considered to be magic numbers.

24 is a magic number
Open

            _reels.height = Browser.window.innerHeight - (24 * _scale);

Checks that there are no magic numbers. By default, -1, 0, 1, and 2 are not considered to be magic numbers.

12 is a magic number
Open

        style.fontSize = 12;

Checks that there are no magic numbers. By default, -1, 0, 1, and 2 are not considered to be magic numbers.

5 is a magic number
Open

            if (_ex < 5) _ex++;

Checks that there are no magic numbers. By default, -1, 0, 1, and 2 are not considered to be magic numbers.

0xFFFFFF is a magic number
Open

        backgroundColor = 0xFFFFFF;

Checks that there are no magic numbers. By default, -1, 0, 1, and 2 are not considered to be magic numbers.

0.5 is a magic number
Open

        _reels.anchor.set(0.5);

Checks that there are no magic numbers. By default, -1, 0, 1, and 2 are not considered to be magic numbers.

Variable _pr type not specified
Open

    var _pr = Math.min(Math.floor(Browser.window.devicePixelRatio), 2);

Checks if type is specified or not for member variables.

String /symbols/images/symbols.png appears 4 times in the file
Open

        _loader.add("ex4/scale-" + _scale + "/symbols/images/symbols.png");

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String /symbols/images/symbols.png appears 6 times in the file
Open

            _loader.add("ex1/scale-" + _scale2 + "/symbols/images/symbols.png");

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String ex3/scale- appears 4 times in the file
Open

            _loader.add("ex3/scale-" + _scale2 + "/symbols/images/symbols.png");

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String /symbols/images/symbols.png appears 9 times in the file
Open

            _loader.add("ex4/scale-" + _scale2 + "/symbols/images/symbols.png");

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String ex appears 4 times in the file
Open

            var reelspath:String = "ex" + _ex + "/scale-" + _scale + "/symbols/images/symbols.png";

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String /symbols/images/symbols.png appears 12 times in the file
Open

            var reelspath:String = "ex" + _ex + "/scale-" + _scale + "/symbols/images/symbols.png";

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String Scale: appears 3 times in the file
Open

                _label.text = "Scale: " + _scale2 + " DPR: " + _pr;

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String /scale- appears 7 times in the file
Open

                bgPath = "ex" + _ex + "/scale-" + _scale + "/background/images/background.png";

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

Invalid variable _ex initialisation (move initialisation to constructor or function)
Open

    var _ex:Int = 1;

Checks for instance variables that are initialised at class level.

String /background/images/background.png appears 9 times in the file
Open

                bgPath = "ex" + _ex + "/scale-" + _scale2 + "/background/images/background.png";

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String /scale- appears 6 times in the file
Open

                reelspath = "ex" + _ex + "/scale-" + _scale2 + "/symbols/images/symbols.png";

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String /scale- appears 3 times in the file
Open

            var bgPath:String = "ex" + _ex + "/scale-" + _scale + "/background/images/background.png";

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String /symbols/images/symbols.png appears 14 times in the file
Open

                reelspath = "ex" + _ex + "/scale-" + _scale + "/symbols/images/symbols.png";

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String /symbols/images/symbols.png appears 7 times in the file
Open

            _loader.add("ex2/scale-" + _scale2 + "/symbols/images/symbols.png");

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String /background/images/background.png appears 6 times in the file
Open

            _loader.add("ex3/scale-" + _scale2 + "/background/images/background.png");

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String /symbols/images/symbols.png appears 10 times in the file
Open

            _loader.add("ex5/scale-" + _scale2 + "/symbols/images/symbols.png");

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String /background/images/background.png appears 4 times in the file
Open

            _loader.add("ex1/scale-" + _scale2 + "/background/images/background.png");

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String /symbols/images/symbols.png appears 5 times in the file
Open

        _loader.add("ex5/scale-" + _scale + "/symbols/images/symbols.png");

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String ex1/scale- appears 3 times in the file
Open

            _loader.add("ex1/scale-" + _scale2 + "/background/images/background.png");

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String ex appears 7 times in the file
Open

                bgPath = "ex" + _ex + "/scale-" + _scale + "/background/images/background.png";

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String ex2/scale- appears 4 times in the file
Open

            _loader.add("ex2/scale-" + _scale2 + "/symbols/images/symbols.png");

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String ex3/scale- appears 3 times in the file
Open

            _loader.add("ex3/scale-" + _scale2 + "/background/images/background.png");

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String /scale- appears 4 times in the file
Open

            var reelspath:String = "ex" + _ex + "/scale-" + _scale + "/symbols/images/symbols.png";

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String /background/images/background.png appears 8 times in the file
Open

            var bgPath:String = "ex" + _ex + "/scale-" + _scale + "/background/images/background.png";

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String ex1/scale- appears 4 times in the file
Open

            _loader.add("ex1/scale-" + _scale2 + "/symbols/images/symbols.png");

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String ex2/scale- appears 3 times in the file
Open

            _loader.add("ex2/scale-" + _scale2 + "/background/images/background.png");

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String /background/images/background.png appears 7 times in the file
Open

        var bgPath:String = "ex" + _ex + "/scale-" + _scale + "/background/images/background.png";

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String ex appears 6 times in the file
Open

                reelspath = "ex" + _ex + "/scale-" + _scale2 + "/symbols/images/symbols.png";

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String /background/images/background.png appears 10 times in the file
Open

                bgPath = "ex" + _ex + "/scale-" + _scale + "/background/images/background.png";

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String ex appears 8 times in the file
Open

                reelspath = "ex" + _ex + "/scale-" + _scale + "/symbols/images/symbols.png";

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String ex appears 5 times in the file
Open

                bgPath = "ex" + _ex + "/scale-" + _scale2 + "/background/images/background.png";

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String DPR: appears 3 times in the file
Open

                _label.text = "Scale: " + _scale2 + " DPR: " + _pr;

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

Invalid variable _pr initialisation (move initialisation to constructor or function)
Open

    var _pr = Math.min(Math.floor(Browser.window.devicePixelRatio), 2);

Checks for instance variables that are initialised at class level.

Invalid variable _baseSize initialisation (move initialisation to constructor or function)
Open

    var _baseSize:Int = 320;

Checks for instance variables that are initialised at class level.

String /scale- appears 5 times in the file
Open

                bgPath = "ex" + _ex + "/scale-" + _scale2 + "/background/images/background.png";

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String /background/images/background.png appears 3 times in the file
Open

        _loader.add("ex3/scale-" + _scale + "/background/images/background.png");

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String ex appears 3 times in the file
Open

            var bgPath:String = "ex" + _ex + "/scale-" + _scale + "/background/images/background.png";

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String /scale- appears 8 times in the file
Open

                reelspath = "ex" + _ex + "/scale-" + _scale + "/symbols/images/symbols.png";

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String /symbols/images/symbols.png appears 3 times in the file
Open

        _loader.add("ex3/scale-" + _scale + "/symbols/images/symbols.png");

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String /background/images/background.png appears 5 times in the file
Open

            _loader.add("ex2/scale-" + _scale2 + "/background/images/background.png");

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String /symbols/images/symbols.png appears 13 times in the file
Open

                reelspath = "ex" + _ex + "/scale-" + _scale2 + "/symbols/images/symbols.png";

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String /symbols/images/symbols.png appears 8 times in the file
Open

            _loader.add("ex3/scale-" + _scale2 + "/symbols/images/symbols.png");

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

String /symbols/images/symbols.png appears 11 times in the file
Open

        var reelspath:String = "ex" + _ex + "/scale-" + _scale + "/symbols/images/symbols.png";

Checks for multiple occurrences of the same string literal within a single file. Code duplication makes maintenance more difficult, so it's better to replace the multiple occurrences with a constant.

Invalid method name signature: main (name should be ~/^_[a-z][a-zA-Z0-9]*$/)
Open

    static function main() {
        new Main();
    }

Checks that method names conform to a format specified by the format property.

Too many consecutive empty lines (> 1)
Open


Checks for consecutive empty lines (default is 1). Also have options to check empty line separators after package, single-line and multi-line comments and class/interface/abstract declarations.

There are no issues that match your filters.

Category
Status