Sign upLogin

plainblack/Lacuna-Web-Client

View on GitHub
Star
app/js/components/menu/bottomBar/resourceToolTip.jsx

Summary

Maintainability
B
4 hrs
Test Coverage

Function getResourceStatus has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    getResourceStatus : function(hour, stored, capicity, hasCapicity) {
        // Different players have differnet strategies regarding waste. Some would consider full
        // waste good. Some would consider empty waste good. Therefore, we shouldn't comment
        // on what a player does or does not do with their waste.
        if (this.props.type === 'waste') {
Severity: Minor
Found in app/js/components/menu/bottomBar/resourceToolTip.jsx - About 1 hr to fix

    Function render has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        render : function() {
        var body = this.props.body;

        var hour     = body[this.props.type + '_hour'];
        var stored   = body[this.props.type + '_stored'] || body[this.props.type] || 0;
    Severity: Minor
    Found in app/js/components/menu/bottomBar/resourceToolTip.jsx - About 1 hr to fix

      Function getResourceStatus has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          getResourceStatus : function(hour, stored, capicity, hasCapicity) {
        // Different players have differnet strategies regarding waste. Some would consider full
        // waste good. Some would consider empty waste good. Therefore, we shouldn't comment
        // on what a player does or does not do with their waste.
        if (this.props.type === 'waste') {
      Severity: Minor
      Found in app/js/components/menu/bottomBar/resourceToolTip.jsx - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

                  return (
                <div>
                    <i className="large green thumbs up icon"></i>
                    Going up
                </div>
      Severity: Major
      Found in app/js/components/menu/bottomBar/resourceToolTip.jsx - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return (
                <div>
                    <i className="large red warning circle icon"></i>
                    <strong>Danger!</strong>
                </div>
        Severity: Major
        Found in app/js/components/menu/bottomBar/resourceToolTip.jsx - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status