plainblack/Lacuna-Web-Client

View on GitHub

Showing 1,320 of 1,320 total issues

Similar blocks of code found in 8 locations. Consider refactoring.
Open

                        <div className="ui red button" onClick={this.onClickClose}>
                            <i className="remove icon"></i>
                        </div>
Severity: Major
Found in app/js/components/window/captcha.jsx and 7 other locations - About 30 mins to fix
app/js/components/window/captcha.jsx on lines 124..126
app/js/components/window/captcha.jsx on lines 127..129
app/js/components/window/essentia/getEssentiaTab.jsx on lines 33..36
app/js/components/window/essentia/getEssentiaTab.jsx on lines 53..56
app/js/components/window/sitterManager/authorizeEmpiresTab.jsx on lines 40..46
app/js/components/window/sitterManager/currentSittersTab.jsx on lines 33..36
app/js/components/window/sitterManager/currentSittersTab.jsx on lines 37..40

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            this.service.propose_broadcast_on_network19({
                session_id : Game.GetSession(''),
                building_id : this.building.id,
                message : Dom.get("proposeBroadcastMessage").value
            },
Severity: Minor
Found in app/js-yui/module/parliament.js and 2 other locations - About 30 mins to fix
app/js-yui/building/embassy.js on lines 591..595
app/js-yui/building/embassy.js on lines 786..790

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

                this.service.leave_alliance({
                    session_id:Game.GetSession(""),
                    building_id:this.building.id,
                    message:Dom.get("embassyAllianceLeaveReason").value
                }, {
Severity: Minor
Found in app/js-yui/building/embassy.js and 2 other locations - About 30 mins to fix
app/js-yui/building/embassy.js on lines 591..595
app/js-yui/module/parliament.js on lines 649..653

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 19 locations. Consider refactoring.
Open

                "boost_spy_training" : {
                    "description": "Spends 5 essentia, and boosts spy training on all planets for 7 days. If a boost is already underway, calling again will add 7 more days.",
                    "parameters": [
                        {"name":"session_id", "type":"string", "optional":false}
                    ],
Severity: Major
Found in app/js-yui/smd.js and 18 other locations - About 30 mins to fix
app/js-yui/smd.js on lines 75..79
app/js-yui/smd.js on lines 310..316
app/js-yui/smd.js on lines 354..358
app/js-yui/smd.js on lines 359..363
app/js-yui/smd.js on lines 1002..1008
app/js-yui/smd.js on lines 1590..1596
app/js-yui/smd.js on lines 2884..2890
app/js-yui/smd.js on lines 2903..2909
app/js-yui/smd.js on lines 2910..2916
app/js-yui/smd.js on lines 2956..2962
app/js-yui/smd.js on lines 3150..3156
app/js-yui/smd.js on lines 3164..3170
app/js-yui/smd.js on lines 3171..3177
app/js-yui/smd.js on lines 3222..3228
app/js-yui/smd.js on lines 3237..3243
app/js-yui/smd.js on lines 3258..3264
app/js-yui/smd.js on lines 3276..3282
app/js-yui/smd.js on lines 3482..3486

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 19 locations. Consider refactoring.
Open

                "fetch" : {
                    "description": "Retrieves a captcha that is required in order to call the solve method.",
                    "parameters": [
                        {"name":"session_id", "type":"string", "optional":false}
                    ],
Severity: Major
Found in app/js-yui/smd.js and 18 other locations - About 30 mins to fix
app/js-yui/smd.js on lines 75..79
app/js-yui/smd.js on lines 310..316
app/js-yui/smd.js on lines 354..358
app/js-yui/smd.js on lines 359..363
app/js-yui/smd.js on lines 1002..1008
app/js-yui/smd.js on lines 1590..1596
app/js-yui/smd.js on lines 2884..2890
app/js-yui/smd.js on lines 2903..2909
app/js-yui/smd.js on lines 2910..2916
app/js-yui/smd.js on lines 2956..2962
app/js-yui/smd.js on lines 3150..3156
app/js-yui/smd.js on lines 3157..3163
app/js-yui/smd.js on lines 3164..3170
app/js-yui/smd.js on lines 3171..3177
app/js-yui/smd.js on lines 3222..3228
app/js-yui/smd.js on lines 3237..3243
app/js-yui/smd.js on lines 3258..3264
app/js-yui/smd.js on lines 3482..3486

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 19 locations. Consider refactoring.
Open

                    "cancel_build" : {
                        "description": "Cancel any one building on the build queue.",
                        "parameters": [{"name":"args", "type":"object", "optional":false}],
                        "returns":{"type":"object"}
                    },
Severity: Major
Found in app/js-yui/smd.js and 18 other locations - About 30 mins to fix
app/js-yui/smd.js on lines 75..79
app/js-yui/smd.js on lines 310..316
app/js-yui/smd.js on lines 354..358
app/js-yui/smd.js on lines 1002..1008
app/js-yui/smd.js on lines 1590..1596
app/js-yui/smd.js on lines 2884..2890
app/js-yui/smd.js on lines 2903..2909
app/js-yui/smd.js on lines 2910..2916
app/js-yui/smd.js on lines 2956..2962
app/js-yui/smd.js on lines 3150..3156
app/js-yui/smd.js on lines 3157..3163
app/js-yui/smd.js on lines 3164..3170
app/js-yui/smd.js on lines 3171..3177
app/js-yui/smd.js on lines 3222..3228
app/js-yui/smd.js on lines 3237..3243
app/js-yui/smd.js on lines 3258..3264
app/js-yui/smd.js on lines 3276..3282
app/js-yui/smd.js on lines 3482..3486

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 19 locations. Consider refactoring.
Open

                "redefine_species_limits" : {
                    "description": "Defines the extra limits placed upon a user that want's to redefine their species.",
                    "parameters": [
                        {"name":"session_id", "type":"string", "optional":false}
                    ],
Severity: Major
Found in app/js-yui/smd.js and 18 other locations - About 30 mins to fix
app/js-yui/smd.js on lines 75..79
app/js-yui/smd.js on lines 310..316
app/js-yui/smd.js on lines 354..358
app/js-yui/smd.js on lines 359..363
app/js-yui/smd.js on lines 1002..1008
app/js-yui/smd.js on lines 1590..1596
app/js-yui/smd.js on lines 2884..2890
app/js-yui/smd.js on lines 2903..2909
app/js-yui/smd.js on lines 2910..2916
app/js-yui/smd.js on lines 2956..2962
app/js-yui/smd.js on lines 3150..3156
app/js-yui/smd.js on lines 3157..3163
app/js-yui/smd.js on lines 3164..3170
app/js-yui/smd.js on lines 3171..3177
app/js-yui/smd.js on lines 3237..3243
app/js-yui/smd.js on lines 3258..3264
app/js-yui/smd.js on lines 3276..3282
app/js-yui/smd.js on lines 3482..3486

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 19 locations. Consider refactoring.
Open

                "view_species_stats" : {
                    "description": "Returns a list of the stats associated with an empire's species as it was originally created.",
                    "parameters": [
                        {"name":"session_id", "type":"string", "optional":false}
                    ],
Severity: Major
Found in app/js-yui/smd.js and 18 other locations - About 30 mins to fix
app/js-yui/smd.js on lines 75..79
app/js-yui/smd.js on lines 310..316
app/js-yui/smd.js on lines 354..358
app/js-yui/smd.js on lines 359..363
app/js-yui/smd.js on lines 1002..1008
app/js-yui/smd.js on lines 1590..1596
app/js-yui/smd.js on lines 2884..2890
app/js-yui/smd.js on lines 2903..2909
app/js-yui/smd.js on lines 2910..2916
app/js-yui/smd.js on lines 2956..2962
app/js-yui/smd.js on lines 3150..3156
app/js-yui/smd.js on lines 3157..3163
app/js-yui/smd.js on lines 3164..3170
app/js-yui/smd.js on lines 3171..3177
app/js-yui/smd.js on lines 3222..3228
app/js-yui/smd.js on lines 3258..3264
app/js-yui/smd.js on lines 3276..3282
app/js-yui/smd.js on lines 3482..3486

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            var data = {
                session_id: Game.GetSession(""),
                building_id: this.building.id,
                name: Dom.get("embassyCreateName").value
            };
Severity: Minor
Found in app/js-yui/building/embassy.js and 2 other locations - About 30 mins to fix
app/js-yui/building/embassy.js on lines 786..790
app/js-yui/module/parliament.js on lines 649..653

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                if(!noEvent) {
                    Event.delegate(nLi, 'click', this.ShipScuttle, 'button.scuttle', {Self:this,Ship:ship,Line:nLi}, true);
                }
Severity: Minor
Found in app/js-yui/building/spacePort.js and 1 other location - About 30 mins to fix
app/js-yui/building/spacePort.js on lines 534..536

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 19 locations. Consider refactoring.
Open

                "get_status" : {
                    "description": "get quick empire status",
                    "parameters": [
                        {"name":"session_id", "type":"string", "optional":false}
                    ],
Severity: Major
Found in app/js-yui/smd.js and 18 other locations - About 30 mins to fix
app/js-yui/smd.js on lines 75..79
app/js-yui/smd.js on lines 310..316
app/js-yui/smd.js on lines 354..358
app/js-yui/smd.js on lines 359..363
app/js-yui/smd.js on lines 1002..1008
app/js-yui/smd.js on lines 1590..1596
app/js-yui/smd.js on lines 2884..2890
app/js-yui/smd.js on lines 2903..2909
app/js-yui/smd.js on lines 2910..2916
app/js-yui/smd.js on lines 3150..3156
app/js-yui/smd.js on lines 3157..3163
app/js-yui/smd.js on lines 3164..3170
app/js-yui/smd.js on lines 3171..3177
app/js-yui/smd.js on lines 3222..3228
app/js-yui/smd.js on lines 3237..3243
app/js-yui/smd.js on lines 3258..3264
app/js-yui/smd.js on lines 3276..3282
app/js-yui/smd.js on lines 3482..3486

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 19 locations. Consider refactoring.
Open

                "enable_self_destruct" : {
                    "description": "Enables a destruction countdown of 24 hours. Sometime after the timer runs out, the empire will vaporize.",
                    "parameters": [
                        {"name":"session_id", "type":"string", "optional":false}
                    ],
Severity: Major
Found in app/js-yui/smd.js and 18 other locations - About 30 mins to fix
app/js-yui/smd.js on lines 75..79
app/js-yui/smd.js on lines 310..316
app/js-yui/smd.js on lines 354..358
app/js-yui/smd.js on lines 359..363
app/js-yui/smd.js on lines 1002..1008
app/js-yui/smd.js on lines 1590..1596
app/js-yui/smd.js on lines 2884..2890
app/js-yui/smd.js on lines 2903..2909
app/js-yui/smd.js on lines 2910..2916
app/js-yui/smd.js on lines 2956..2962
app/js-yui/smd.js on lines 3150..3156
app/js-yui/smd.js on lines 3157..3163
app/js-yui/smd.js on lines 3171..3177
app/js-yui/smd.js on lines 3222..3228
app/js-yui/smd.js on lines 3237..3243
app/js-yui/smd.js on lines 3258..3264
app/js-yui/smd.js on lines 3276..3282
app/js-yui/smd.js on lines 3482..3486

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 19 locations. Consider refactoring.
Open

                "boost_building" : {
                    "description": "Spends 5 essentia, and boosts building queues on all planets for 7 days. If a boost is already underway, calling again will add 7 more days.",
                    "parameters": [
                        {"name":"session_id", "type":"string", "optional":false}
                    ],
Severity: Major
Found in app/js-yui/smd.js and 18 other locations - About 30 mins to fix
app/js-yui/smd.js on lines 75..79
app/js-yui/smd.js on lines 310..316
app/js-yui/smd.js on lines 354..358
app/js-yui/smd.js on lines 359..363
app/js-yui/smd.js on lines 1002..1008
app/js-yui/smd.js on lines 1590..1596
app/js-yui/smd.js on lines 2884..2890
app/js-yui/smd.js on lines 2903..2909
app/js-yui/smd.js on lines 2910..2916
app/js-yui/smd.js on lines 2956..2962
app/js-yui/smd.js on lines 3157..3163
app/js-yui/smd.js on lines 3164..3170
app/js-yui/smd.js on lines 3171..3177
app/js-yui/smd.js on lines 3222..3228
app/js-yui/smd.js on lines 3237..3243
app/js-yui/smd.js on lines 3258..3264
app/js-yui/smd.js on lines 3276..3282
app/js-yui/smd.js on lines 3482..3486

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 19 locations. Consider refactoring.
Open

                "disable_self_destruct" : {
                    "description": "Disables the self distruction countdown.",
                    "parameters": [
                        {"name":"session_id", "type":"string", "optional":false}
                    ],
Severity: Major
Found in app/js-yui/smd.js and 18 other locations - About 30 mins to fix
app/js-yui/smd.js on lines 75..79
app/js-yui/smd.js on lines 310..316
app/js-yui/smd.js on lines 354..358
app/js-yui/smd.js on lines 359..363
app/js-yui/smd.js on lines 1002..1008
app/js-yui/smd.js on lines 1590..1596
app/js-yui/smd.js on lines 2884..2890
app/js-yui/smd.js on lines 2903..2909
app/js-yui/smd.js on lines 2910..2916
app/js-yui/smd.js on lines 2956..2962
app/js-yui/smd.js on lines 3150..3156
app/js-yui/smd.js on lines 3157..3163
app/js-yui/smd.js on lines 3164..3170
app/js-yui/smd.js on lines 3222..3228
app/js-yui/smd.js on lines 3237..3243
app/js-yui/smd.js on lines 3258..3264
app/js-yui/smd.js on lines 3276..3282
app/js-yui/smd.js on lines 3482..3486

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                if(!noEvent) {
                    Event.delegate(nLi, 'click', this.ShipRecall, 'button.recall', {Self:this,Ship:ship,Line:nLi}, true);
                }
Severity: Minor
Found in app/js-yui/building/spacePort.js and 1 other location - About 30 mins to fix
app/js-yui/building/spacePort.js on lines 511..513

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

                            <div className="ui red button" onClick={this.handleDeauthorizeAll}>
                                <i className="warning sign icon"></i>
                                Revoke all
                            </div>
Severity: Major
Found in app/js/components/window/sitterManager/currentSittersTab.jsx and 7 other locations - About 30 mins to fix
app/js/components/window/captcha.jsx on lines 124..126
app/js/components/window/captcha.jsx on lines 127..129
app/js/components/window/captcha.jsx on lines 130..132
app/js/components/window/essentia/getEssentiaTab.jsx on lines 33..36
app/js/components/window/essentia/getEssentiaTab.jsx on lines 53..56
app/js/components/window/sitterManager/authorizeEmpiresTab.jsx on lines 40..46
app/js/components/window/sitterManager/currentSittersTab.jsx on lines 33..36

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                failure : function(o){
                    if(this.Input) {
                        this.Input.value = this.Spy.name;
                    }
                },
Severity: Minor
Found in app/js-yui/building/intelligence.js and 1 other location - About 30 mins to fix
app/js-yui/building/spacePort.js on lines 719..723

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 19 locations. Consider refactoring.
Open

                    "generate_singularity" : {
                        "description": "Performs action on specified target.",
                        "parameters": [
                            {"name":"params", "type":"object", "optional":false}
                        ],
Severity: Major
Found in app/js-yui/smd.js and 18 other locations - About 30 mins to fix
app/js-yui/smd.js on lines 75..79
app/js-yui/smd.js on lines 354..358
app/js-yui/smd.js on lines 359..363
app/js-yui/smd.js on lines 1002..1008
app/js-yui/smd.js on lines 1590..1596
app/js-yui/smd.js on lines 2884..2890
app/js-yui/smd.js on lines 2903..2909
app/js-yui/smd.js on lines 2910..2916
app/js-yui/smd.js on lines 2956..2962
app/js-yui/smd.js on lines 3150..3156
app/js-yui/smd.js on lines 3157..3163
app/js-yui/smd.js on lines 3164..3170
app/js-yui/smd.js on lines 3171..3177
app/js-yui/smd.js on lines 3222..3228
app/js-yui/smd.js on lines 3237..3243
app/js-yui/smd.js on lines 3258..3264
app/js-yui/smd.js on lines 3276..3282
app/js-yui/smd.js on lines 3482..3486

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 19 locations. Consider refactoring.
Open

                "is_name_available" : {
                    "description": "check if empire name is available",
                    "parameters": [
                        {"name":"name", "type":"string", "optional":false}
                    ],
Severity: Major
Found in app/js-yui/smd.js and 18 other locations - About 30 mins to fix
app/js-yui/smd.js on lines 75..79
app/js-yui/smd.js on lines 310..316
app/js-yui/smd.js on lines 354..358
app/js-yui/smd.js on lines 359..363
app/js-yui/smd.js on lines 1002..1008
app/js-yui/smd.js on lines 1590..1596
app/js-yui/smd.js on lines 2884..2890
app/js-yui/smd.js on lines 2910..2916
app/js-yui/smd.js on lines 2956..2962
app/js-yui/smd.js on lines 3150..3156
app/js-yui/smd.js on lines 3157..3163
app/js-yui/smd.js on lines 3164..3170
app/js-yui/smd.js on lines 3171..3177
app/js-yui/smd.js on lines 3222..3228
app/js-yui/smd.js on lines 3237..3243
app/js-yui/smd.js on lines 3258..3264
app/js-yui/smd.js on lines 3276..3282
app/js-yui/smd.js on lines 3482..3486

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function onTickerTick has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    onTickerTick : function() {

        var body = clone(this.state);

        var tickIncoming = function(ship) {
Severity: Minor
Found in app/js/stores/rpc/body.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language