planio-gmbh/rackstash

View on GitHub
lib/rackstash/buffered_logger.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Class BufferedLogger has 29 methods (exceeds 20 allowed). Consider refactoring.
Open

  class BufferedLogger
    extend Forwardable
    include Rackstash::LogSeverity

    class SimpleFormatter < ::Logger::Formatter
Severity: Minor
Found in lib/rackstash/buffered_logger.rb - About 3 hrs to fix

    Method add has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def add(severity, message=nil, progname=nil)
          severity ||= UNKNOWN
          return true if level > severity
    
          progname ||= logger.progname if logger.respond_to?(:progname)
    Severity: Minor
    Found in lib/rackstash/buffered_logger.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method flush_and_pop_buffer has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def flush_and_pop_buffer
          if buffer = self.buffer
            unless buffer[:do_not_log]
              json = logstash_event(buffer[:messages], buffer[:fields], buffer[:tags])
              log_level = Rackstash.respond_to?(:log_level) ? Rackstash.log_level : :info
    Severity: Minor
    Found in lib/rackstash/buffered_logger.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status