Showing 7 of 7 total issues

Method matches_path? has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

      def matches_path?(path)
        return false if path.length < members.length
        return false unless members.last.matches?(path.last)

        path_idx = path.length    - 2
Severity: Minor
Found in lib/hexp/css_selector.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method tag! has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def tag!(tag, *args, &block)
      text, attributes = nil, {}
      args.each do |arg|
        case arg
        when ::Hash
Severity: Minor
Found in lib/hexp/builder.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def initialize(*args)
      tag_ok   = args[0].instance_of?(Symbol)
      raise "The tag of node should be a Symbol" unless tag_ok

      attrs_ok = args[1].instance_of?(Hash) &&
Severity: Minor
Found in lib/hexp/node.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

          return response.to_ary
Severity: Major
Found in lib/hexp/node/rewriter.rb - About 30 mins to fix

    Method coerce_rewrite_response has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def coerce_rewrite_response(response)
            return [] if response.nil?
    
            return [response.to_hexp] if response.respond_to? :to_hexp
            return [response.to_str]  if response.respond_to? :to_str
    Severity: Minor
    Found in lib/hexp/node/rewriter.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method call has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def call(node)
            return node.text if node.text? || node.cdata?
    
            unless node.attributes.empty?
              attrs = node.attributes.map do |key, value|
    Severity: Minor
    Found in lib/hexp/nokogiri/reader.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method set_attr has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def set_attr(name, value)
          if value.nil?
            new_attrs = {}
            attributes.each do |nam,val|
              new_attrs[nam] = val unless nam == name.to_s
    Severity: Minor
    Found in lib/hexp/node.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language