plouc/mozaik

View on GitHub
packages/server/src/bus.ts

Summary

Maintainability
C
1 day
Test Coverage

Function subscribe has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public subscribe(clientId: string, subscription: Subscription) {
        if (!this.clients[clientId]) {
            this.logger.error(`Unable to find a client with id '${clientId}'`)
            return
        }
Severity: Major
Found in packages/server/src/bus.ts - About 2 hrs to fix

    Function subscribe has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        public subscribe(clientId: string, subscription: Subscription) {
            if (!this.clients[clientId]) {
                this.logger.error(`Unable to find a client with id '${clientId}'`)
                return
            }
    Severity: Minor
    Found in packages/server/src/bus.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function unsubscribe has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public unsubscribe(clientId: string, subscriptionId: string) {
            if (!this.clients[clientId]) {
                this.logger.warn(
                    chalk.magenta(
                        `unable to unsubscribe from '${subscriptionId}', client with id '${clientId}' does not exist`
    Severity: Minor
    Found in packages/server/src/bus.ts - About 1 hr to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              if (api.methods[apiMethod] === undefined) {
                  errMsg = `Unable to find API method matching '${apiMethod}'`
                  this.logger.error(chalk.red(errMsg))
      
                  throw new Error(errMsg)
      Severity: Major
      Found in packages/server/src/bus.ts and 2 other locations - About 45 mins to fix
      packages/server/src/bus.ts on lines 200..205
      packages/server/src/bus.ts on lines 208..213

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              if (parts.length < 2) {
                  errMsg = `Invalid subscription id '${subscriptionId}', should be something like 'api_id.method'`
                  this.logger.error(chalk.red(errMsg))
      
                  throw new Error(errMsg)
      Severity: Major
      Found in packages/server/src/bus.ts and 2 other locations - About 45 mins to fix
      packages/server/src/bus.ts on lines 208..213
      packages/server/src/bus.ts on lines 216..221

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              if (this.apis[apiId] === undefined) {
                  errMsg = `Unable to find API matching id '${apiId}'`
                  this.logger.error(chalk.red(errMsg))
      
                  throw new Error(errMsg)
      Severity: Major
      Found in packages/server/src/bus.ts and 2 other locations - About 45 mins to fix
      packages/server/src/bus.ts on lines 200..205
      packages/server/src/bus.ts on lines 216..221

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if (this.apis[id] !== undefined) {
                  const errMsg = `API '${id}' already registered`
                  this.logger.error(chalk.red(errMsg))
      
                  throw new Error(errMsg)
      Severity: Minor
      Found in packages/server/src/bus.ts and 1 other location - About 45 mins to fix
      packages/server/src/bus.ts on lines 82..87

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if (mode !== PollMode.Poll && mode !== PollMode.Push) {
                  const errMsg = `API mode '${mode}' is not a valid mode, must be one of 'poll' or 'push'`
                  this.logger.error(chalk.red(errMsg))
      
                  throw new Error(errMsg)
      Severity: Minor
      Found in packages/server/src/bus.ts and 1 other location - About 45 mins to fix
      packages/server/src/bus.ts on lines 89..94

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  if (subscription.clients.length === 0 && subscription.timer) {
                      this.logger.info(
                          `no client found for subscription '${subscriptionId}' removing scheduler`
                      )
      
      
      Severity: Minor
      Found in packages/server/src/bus.ts and 1 other location - About 40 mins to fix
      packages/server/src/bus.ts on lines 311..318

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  if (subscription.timer) {
                      this.logger.info(
                          `no more client found for subscription '${subscriptionId}' removing scheduler`
                      )
      
      
      Severity: Minor
      Found in packages/server/src/bus.ts and 1 other location - About 40 mins to fix
      packages/server/src/bus.ts on lines 133..140

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status