Sign upLogin

pluf/bank

View on GitHub
Star
src/Bank/Views/Transfer.php

Summary

Maintainability
B
6 hrs
Test Coverage

Method create has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function create($request, $match)
    {
        // Check amount
        $amount = $request->REQUEST['amount'];
        if ($amount <= 0.0) {
Severity: Major
Found in src/Bank/Views/Transfer.php - About 2 hrs to fix

    Method createPayment has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function createPayment($request, $match)
    {
        // Check wallet and permissions to access wallet
        Pluf::loadFunction('Pluf_Shortcuts_GetObjectOr404');
        $toWallet = Pluf_Shortcuts_GetObjectOr404('Bank_Wallet', $match['parentId']);
    Severity: Minor
    Found in src/Bank/Views/Transfer.php - About 1 hr to fix

      Method getPayment has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getPayment($request, $match)
    {
        Pluf::loadFunction('Pluf_Shortcuts_GetObjectOr404');
        // Check wallets and permissions to access wallets
        $wallet = Pluf_Shortcuts_GetObjectOr404('Bank_Wallet', $match['parentId']);
      Severity: Minor
      Found in src/Bank/Views/Transfer.php - About 1 hr to fix

        Function create has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function create($request, $match)
    {
        // Check amount
        $amount = $request->REQUEST['amount'];
        if ($amount <= 0.0) {
        Severity: Minor
        Found in src/Bank/Views/Transfer.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getPayment has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getPayment($request, $match)
    {
        Pluf::loadFunction('Pluf_Shortcuts_GetObjectOr404');
        // Check wallets and permissions to access wallets
        $wallet = Pluf_Shortcuts_GetObjectOr404('Bank_Wallet', $match['parentId']);
        Severity: Minor
        Found in src/Bank/Views/Transfer.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status