Sign upLogin

pluf/core

View on GitHub
Star

Showing 197 of 197 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
namespace Pluf\Core\Exception;


use Pluf\Orm\Attribute\Entity;
Severity: Major
Found in src/Exception/ResourceNotFoundException.php and 1 other location - About 2 hrs to fix
src/Exception/UnhandledException.php on lines 1..19

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 132.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
namespace Pluf\Core\Exception;

use Pluf\Orm\Attribute\Entity;
use Pluf\Orm\Attribute\Column;
Severity: Major
Found in src/Exception/UnhandledException.php and 1 other location - About 2 hrs to fix
src/Exception/ResourceNotFoundException.php on lines 1..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 132.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function getMimeType has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public function getMimeType($file)
    {
        static $mimes = null;
        $info = pathinfo($file);
        if (isset($info['extension'])) {
Severity: Minor
Found in src/Process/Http/FileToResponse.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __invoke has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function __invoke(ServerRequestInterface $request, ResponseInterface $response, UnitTrackerInterface $unitTracker)
    {
        $filePath = $unitTracker->next();
        $fileName = basename($filePath);
Severity: Minor
Found in src/Process/Http/FileToResponse.php - About 1 hr to fix

    Avoid excessively long variable names like $modelDescriptionRepository. Keep variable name length under 20.
    Open

        public function generateEntities($type, $modelDescriptionRepository, $data)
    Severity: Minor
    Found in src/Process/HttpBodyToEntities.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Avoid excessively long variable names like $contentTypesWithParsedBodies. Keep variable name length under 20.
    Open

            $contentTypesWithParsedBodies = [
    Severity: Minor
    Found in src/Process/HttpBodyToEntities.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Avoid excessively long variable names like $modelDescriptionRepository. Keep variable name length under 20.
    Open

        public function __invoke(ModelDescriptionRepository $modelDescriptionRepository, ServerRequestInterface $request, UnitTrackerInterface $unitTracker)
    Severity: Minor
    Found in src/Process/HttpBodyToEntities.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Avoid excessively long variable names like $modelDescriptionRepository. Keep variable name length under 20.
    Open

        public function __invoke(EntityManager $entityManager, ModelDescriptionRepository $modelDescriptionRepository, $entity, $itemId)
    Severity: Minor
    Found in src/Process/Entity/UpdateEntity.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Avoid excessively long variable names like $contentTypesWithParsedBodies. Keep variable name length under 20.
    Open

                $contentTypesWithParsedBodies = [
    Severity: Minor
    Found in src/Process/Http/RequestBodyParser.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    Method __invoke has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function __invoke(ServerRequestInterface $request, UnitTrackerInterface $unitTracker)
    {
        // Decode body
        $method = $request->getMethod();
        if ($method === 'POST') {
    Severity: Minor
    Found in src/Process/Http/RequestBodyParser.php - About 1 hr to fix

      Function __invoke has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          function __invoke(ServerRequestInterface $request, ResponseInterface $response, UnitTrackerInterface $unitTracker)
    {
        $filePath = $unitTracker->next();
        $fileName = basename($filePath);
      Severity: Minor
      Found in src/Process/Http/FileToResponse.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __invoke has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function __invoke(ServerRequestInterface $request, UnitTrackerInterface $unitTracker)
    {
        // Decode body
        $method = $request->getMethod();
        if ($method === 'POST') {
      Severity: Minor
      Found in src/Process/Http/RequestBodyParser.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getContentType has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getContentType(ServerRequestInterface $request): string
    {
        $contentTypes = $request->getHeader("Content-Type") ?? [];

        $parsedContentType = 'application/json';
      Severity: Minor
      Found in src/Process/HttpBodyToEntities.php - About 1 hr to fix

        Avoid variables with short names like $id. Configured minimum length is 3.
        Open

                $id = $md->properties[$md->primaryKey];
        Severity: Minor
        Found in src/Process/Entity/UpdateEntity.php by phpmd

        ShortVariable

        Since: 0.2

        Detects when a field, local, or parameter has a very short name.

        Example

        class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

        Source https://phpmd.org/rules/naming.html#shortvariable

        Avoid variables with short names like $t. Configured minimum length is 3.
        Open

            public function convertToSerializable(Throwable $t){
        Severity: Minor
        Found in src/Process/Http/ResponseBodyEncoder.php by phpmd

        ShortVariable

        Since: 0.2

        Detects when a field, local, or parameter has a very short name.

        Example

        class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

        Source https://phpmd.org/rules/naming.html#shortvariable

        Avoid variables with short names like $md. Configured minimum length is 3.
        Open

                $md = $modelDescriptionRepository->get($this->class);
        Severity: Minor
        Found in src/Process/Entity/UpdateEntity.php by phpmd

        ShortVariable

        Since: 0.2

        Detects when a field, local, or parameter has a very short name.

        Example

        class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

        Source https://phpmd.org/rules/naming.html#shortvariable

        Avoid variables with short names like $fh. Configured minimum length is 3.
        Open

                if (! $fh = fopen($filePath, 'r')) {
        Severity: Minor
        Found in src/Process/Http/FileToResponse.php by phpmd

        ShortVariable

        Since: 0.2

        Detects when a field, local, or parameter has a very short name.

        Example

        class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

        Source https://phpmd.org/rules/naming.html#shortvariable

        Avoid variables with short names like $ex. Configured minimum length is 3.
        Open

                $ex = new Exception($this->message, $this->code, $this->previous, $this->params, $this->solutions);
        Severity: Minor
        Found in src/ExceptionBuilder.php by phpmd

        ShortVariable

        Since: 0.2

        Detects when a field, local, or parameter has a very short name.

        Example

        class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

        Source https://phpmd.org/rules/naming.html#shortvariable

        Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function __construct($message = '', ?int $code = null, ?Throwable $previous = null, ?int $status = 500, ?array $params = [], ?array $solutions = [])
        Severity: Minor
        Found in src/Exception.php - About 45 mins to fix

          Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function __construct($message = '', ?int $code = null, ?Throwable $previous = null, ?int $status = 404, ?array $params = [], ?array $solutions = [])
          Severity: Minor
          Found in src/Exception/ResourceNotFoundException.php - About 45 mins to fix
            Severity
            Category
            Status
            Source
            Language