Sign upLogin

pluf/exchange

View on GitHub
Star

Showing 12 of 12 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
return array(
    // ************************************************************* Schema
    array(
        'regex' => '#^/drafts/schema$#',
Severity: Major
Found in src/Exchange/urls/draft.php and 1 other location - About 1 day to fix
src/Exchange/urls/admission.php on lines 1..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 260.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
return array(
    // ************************************************************* Schema
    array(
        'regex' => '#^/admissions/schema$#',
Severity: Major
Found in src/Exchange/urls/admission.php and 1 other location - About 1 day to fix
src/Exchange/urls/draft.php on lines 1..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 260.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method init has 99 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function init()
    {
        $this->_a['table'] = 'exchange_comments';
        $this->_a['verbose'] = 'Exchange_Comments';
        $this->_a['cols'] = array(
Severity: Major
Found in src/Exchange/Comment.php - About 3 hrs to fix

    Method init has 90 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function init()
    {
        $this->_a['table'] = 'exchange_advertisements';
        $this->_a['verbose'] = 'Exchange_Advertisements';
        $this->_a['cols'] = array(
    Severity: Major
    Found in src/Exchange/Advertisement.php - About 3 hrs to fix

      Method init has 76 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function init()
    {
        $this->_a['table'] = 'exchange_offer_history';
        $this->_a['verbose'] = 'Exchange Offer History';
        $this->_a['cols'] = array(
      Severity: Major
      Found in src/Exchange/OfferHistory.php - About 3 hrs to fix

        Method init has 68 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function init()
    {
        $this->_a['table'] = 'exchange_offers';
        $this->_a['verbose'] = 'Exchange_Offers';
        $this->_a['cols'] = array(
        Severity: Major
        Found in src/Exchange/Offer.php - About 2 hrs to fix

          File day.php has 270 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
return array(
    // ************************************************************* Schema
    array(
        'regex' => '#^/days/schema$#',
          Severity: Minor
          Found in src/Exchange/urls/day.php - About 2 hrs to fix

            Method init has 55 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                function init()
    {
        $this->_a['table'] = 'exchange_drafts';
        $this->_a['verbose'] = 'Exchange_Drafts';
        $this->_a['cols'] = array(
            Severity: Major
            Found in src/Exchange/Draft.php - About 2 hrs to fix

              Method init has 40 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  function init()
    {
        $this->_a['table'] = 'exchange_admissions';
        $this->_a['verbose'] = 'Exchange_Admissions';
        $this->_a['cols'] = array(
              Severity: Minor
              Found in src/Exchange/Admission.php - About 1 hr to fix

                Method init has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    function init()
    {
        $this->_a['table'] = 'exchange_offermetadata';
        $this->_a['verbose'] = 'Exchange_OfferMetadata';
        $this->_a['cols'] = array(
                Severity: Minor
                Found in src/Exchange/OfferMetadata.php - About 1 hr to fix

                  Method init has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      function init()
    {
        $this->_a['table'] = 'exchange_currency_rates';
        $this->_a['verbose'] = 'Exchange_CurrencyRate';
        $this->_a['cols'] = array(
                  Severity: Minor
                  Found in src/Exchange/CurrencyRate.php - About 1 hr to fix

                    Function save has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                        function save($commit = true)
    {
        $model = parent::save(false);
        // update the content
        if (array_key_exists('file', $this->cleaned_data)) {
                    Severity: Minor
                    Found in src/Exchange/Form/CommentUpdate.php - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language