Sign upLogin

pluf/workflow

View on GitHub
Star
src/Imp/StateMachineBuilderImpl.php

Summary

Maintainability
F
4 days
Test Coverage

File StateMachineBuilderImpl.php has 584 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace Pluf\Workflow\Imp;

use Pluf\Di\Container;
use Pluf\Workflow\Action;
Severity: Major
Found in src/Imp/StateMachineBuilderImpl.php - About 1 day to fix

    StateMachineBuilderImpl has 63 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class StateMachineBuilderImpl implements UntypedStateMachineBuilder, StateMachineBuilder
{
    use AssertTrait;

    // static {
    Severity: Major
    Found in src/Imp/StateMachineBuilderImpl.php - About 1 day to fix

      Function buildDeclareTransition has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
      Open

          private function buildDeclareTransition(Transit $transit): void
    {
        if (empty($transit)) {
            return;
        }
      Severity: Minor
      Found in src/Imp/StateMachineBuilderImpl.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method buildDeclareTransition has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function buildDeclareTransition(Transit $transit): void
    {
        if (empty($transit)) {
            return;
        }
      Severity: Major
      Found in src/Imp/StateMachineBuilderImpl.php - About 2 hrs to fix

        Function installExtensionMethods has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            private function installExtensionMethods(): void
    {
        foreach ($this->states as $state) {
            // Ignore all the transition start from a final state
            if ($state->isFinalState()) {
        Severity: Minor
        Found in src/Imp/StateMachineBuilderImpl.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function installDeferBoundAction has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            private function installDeferBoundAction(DeferBoundActionInfo $deferBoundActionInfo)
    {
        foreach ($this->states as $mutableState) {
            if (! $deferBoundActionInfo->isFromStateMatch($mutableState->getStateId())) {
                continue;
        Severity: Minor
        Found in src/Imp/StateMachineBuilderImpl.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function walkThroughStateMachineClassForState has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            private function walkThroughStateMachineClassForState(): void
    {
        $stack = [];
        array_push($stack, new ReflectionClass($this->stateMachineImplClazz));
        while (! empty($stack)) {
        Severity: Minor
        Found in src/Imp/StateMachineBuilderImpl.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function walkThroughStateMachineClassForTransition has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            private function walkThroughStateMachineClassForTransition(): void
    {
        $stack = [];
        array_push($stack, new ReflectionClass($this->stateMachineImplClazz));
        while (! empty($stack)) {
        Severity: Minor
        Found in src/Imp/StateMachineBuilderImpl.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function addStateEntryExitMethodCallAction has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            private function addStateEntryExitMethodCallAction(string $methodName, $parameterTypes, MutableState $mutableState, bool $isEntryAction): void
    {
        if ($this->hasMethod($this->stateMachineImplClazz, $methodName)) {
            $weight = Action::EXTENSION_WEIGHT;
            if (str_starts_with($methodName, "before")) {
        Severity: Minor
        Found in src/Imp/StateMachineBuilderImpl.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method defineTimedState has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function defineTimedState($stateId, int $initialDelay, int $timeInterval, $autoEvent, $autoContext): MutableState
        Severity: Minor
        Found in src/Imp/StateMachineBuilderImpl.php - About 35 mins to fix

          Function buildDeclareState has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              private function buildDeclareState(State $state): void
    {
        // Preconditions.checkState(stateConverter!=null, "Do not register state converter");
        $stateId = $state->name;
        // Preconditions.checkNotNull(stateId, "Cannot convert state of name \""+state.name()+"\".");
          Severity: Minor
          Found in src/Imp/StateMachineBuilderImpl.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              private function walkThroughStateMachineClassForTransition(): void
    {
        $stack = [];
        array_push($stack, new ReflectionClass($this->stateMachineImplClazz));
        while (! empty($stack)) {
          Severity: Major
          Found in src/Imp/StateMachineBuilderImpl.php and 1 other location - About 3 hrs to fix
          src/Imp/StateMachineBuilderImpl.php on lines 137..159

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 153.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              private function walkThroughStateMachineClassForState(): void
    {
        $stack = [];
        array_push($stack, new ReflectionClass($this->stateMachineImplClazz));
        while (! empty($stack)) {
          Severity: Major
          Found in src/Imp/StateMachineBuilderImpl.php and 1 other location - About 3 hrs to fix
          src/Imp/StateMachineBuilderImpl.php on lines 161..183

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 153.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status