Sign upLogin

pmonks/alfresco-bulk-import

View on GitHub
Star
amp/src/main/java/org/alfresco/extension/bulkimport/impl/BulkImportStatusImpl.java

Summary

Maintainability
D
2 days
Test Coverage

BulkImportStatusImpl has 60 methods (exceeds 20 allowed). Consider refactoring.
Open

public class BulkImportStatusImpl
    implements WritableBulkImportStatus
{
    // General information
    private AtomicBoolean                inProgress            = new AtomicBoolean(false);
Severity: Major
Found in amp/src/main/java/org/alfresco/extension/bulkimport/impl/BulkImportStatusImpl.java - About 1 day to fix

    File BulkImportStatusImpl.java has 328 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * Copyright (C) 2007 Peter Monks
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
    Severity: Minor
    Found in amp/src/main/java/org/alfresco/extension/bulkimport/impl/BulkImportStatusImpl.java - About 3 hrs to fix

      Method toString has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              @Override
        public String toString()
        {
            String result = null;
      Severity: Minor
      Found in amp/src/main/java/org/alfresco/extension/bulkimport/impl/BulkImportStatusImpl.java - About 1 hr to fix

        Method importStarted has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public void importStarted(final String                       initiatingUserId,
                              final BulkImportSource             source,
                              final String                       targetSpace,
                              final BulkImportThreadPoolExecutor threadPool,
                              final long                         batchWeight,
        Severity: Major
        Found in amp/src/main/java/org/alfresco/extension/bulkimport/impl/BulkImportStatusImpl.java - About 50 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              @Override
    public Long getDurationInNs()
    {
        Long result = null;
          Severity: Major
          Found in amp/src/main/java/org/alfresco/extension/bulkimport/impl/BulkImportStatusImpl.java and 1 other location - About 1 hr to fix
          amp/src/main/java/org/alfresco/extension/bulkimport/impl/BulkImportStatusImpl.java on lines 121..139

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 73.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              @Override
    public Long getScanDurationInNs()
    {
        Long result = null;
          Severity: Major
          Found in amp/src/main/java/org/alfresco/extension/bulkimport/impl/BulkImportStatusImpl.java and 1 other location - About 1 hr to fix
          amp/src/main/java/org/alfresco/extension/bulkimport/impl/BulkImportStatusImpl.java on lines 95..113

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 73.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status