pmonks/alfresco-bulk-import

View on GitHub
amp/src/main/java/org/alfresco/extension/bulkimport/source/fs/AbstractMapBasedMetadataLoader.java

Summary

Maintainability
D
2 days
Test Coverage

Method loadMetadata has a Cognitive Complexity of 76 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public final Metadata loadMetadata(final File metadataFile)
    {
        Metadata result = new Metadata();
        

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method loadMetadata has 86 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    public final Metadata loadMetadata(final File metadataFile)
    {
        Metadata result = new Metadata();
        

    Avoid deeply nested control flow statements.
    Open

                            if (propertyDefinition != null)
                            {
                                if (propertyDefinition.isMultiValued())
                                {
                                    // Multi-valued property

      Avoid deeply nested control flow statements.
      Open

                              for (final String aspectName : aspectNames)
                              {
                                  result.addAspect(aspectName.trim());
                              }

        There are no issues that match your filters.

        Category
        Status