Sign upLogin

pmonks/alfresco-bulk-import

View on GitHub
Star
amp/src/main/java/org/alfresco/extension/bulkimport/source/fs/FilesystemBulkImportSource.java

Summary

Maintainability
D
2 days
Test Coverage

Method scanDirectory has a Cognitive Complexity of 71 (exceeds 5 allowed). Consider refactoring.
Open

    private void scanDirectory(final BulkImportSourceStatus status,
                               final BulkImportCallback     callback,
                               final File                   sourceDirectory,
                               final File                   directory,
                               final boolean                submitFiles)
Severity: Minor
Found in amp/src/main/java/org/alfresco/extension/bulkimport/source/fs/FilesystemBulkImportSource.java - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method scanDirectory has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private void scanDirectory(final BulkImportSourceStatus status,
                               final BulkImportCallback     callback,
                               final File                   sourceDirectory,
                               final File                   directory,
                               final boolean                submitFiles)
Severity: Major
Found in amp/src/main/java/org/alfresco/extension/bulkimport/source/fs/FilesystemBulkImportSource.java - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                            if (lastVersion.getContentFile() != null)
                        {
                            scanDirectory(status,
                                          callback,
                                          sourceDirectory,
    Severity: Major
    Found in amp/src/main/java/org/alfresco/extension/bulkimport/source/fs/FilesystemBulkImportSource.java - About 45 mins to fix

      Method scanDirectory has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          private void scanDirectory(final BulkImportSourceStatus status,
                               final BulkImportCallback     callback,
                               final File                   sourceDirectory,
                               final File                   directory,
                               final boolean                submitFiles)
      Severity: Minor
      Found in amp/src/main/java/org/alfresco/extension/bulkimport/source/fs/FilesystemBulkImportSource.java - About 35 mins to fix

        Method init has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            @Override
    public void init(final BulkImportSourceStatus importStatus, final Map<String, List<String>> parameters)
    {
        final List<String> sourceDirectoryParameterValues = parameters.get(PARAMETER_SOURCE_DIRECTORY);
        String             sourceDirectoryName            = null;
        Severity: Minor
        Found in amp/src/main/java/org/alfresco/extension/bulkimport/source/fs/FilesystemBulkImportSource.java - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method filter has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            private final boolean filter(final FilesystemBulkImportItem item)
    {
        boolean result = false;
        
        if (importFilters != null)
        Severity: Minor
        Found in amp/src/main/java/org/alfresco/extension/bulkimport/source/fs/FilesystemBulkImportSource.java - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    {
                for (final FilesystemBulkImportItem fileItem : fileItems)
                {
                    if (importStatus.isStopping() || Thread.currentThread().isInterrupted()) throw new InterruptedException(Thread.currentThread().getName() + " was interrupted. Terminating early.");
        Severity: Minor
        Found in amp/src/main/java/org/alfresco/extension/bulkimport/source/fs/FilesystemBulkImportSource.java and 1 other location - About 50 mins to fix
        amp/src/main/java/org/alfresco/extension/bulkimport/source/fs/FilesystemBulkImportSource.java on lines 203..213

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    {
                for (final FilesystemBulkImportItem directoryItem : directoryItems)
                {
                    if (importStatus.isStopping() || Thread.currentThread().isInterrupted()) throw new InterruptedException(Thread.currentThread().getName() + " was interrupted. Terminating early.");
        Severity: Minor
        Found in amp/src/main/java/org/alfresco/extension/bulkimport/source/fs/FilesystemBulkImportSource.java and 1 other location - About 50 mins to fix
        amp/src/main/java/org/alfresco/extension/bulkimport/source/fs/FilesystemBulkImportSource.java on lines 216..226

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status