Sign upLogin

pmonks/alfresco-bulk-import

View on GitHub
Star
amp/src/main/java/org/alfresco/extension/bulkimport/util/DataDictionaryBuilderImpl.java

Summary

Maintainability
D
2 days
Test Coverage

Method toString has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public String toString()
    {
        final StringBuilder     result         = new StringBuilder(1024);
        final Collection<Model> dataDictionary = getDataDictionary();
Severity: Minor
Found in amp/src/main/java/org/alfresco/extension/bulkimport/util/DataDictionaryBuilderImpl.java - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method classDefinitionToString has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

    private String classDefinitionToString(final ClassDefinition definition)
    {
        StringBuilder result = null;
        
        if (definition != null)
Severity: Minor
Found in amp/src/main/java/org/alfresco/extension/bulkimport/util/DataDictionaryBuilderImpl.java - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method toString has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    public String toString()
    {
        final StringBuilder     result         = new StringBuilder(1024);
        final Collection<Model> dataDictionary = getDataDictionary();
Severity: Major
Found in amp/src/main/java/org/alfresco/extension/bulkimport/util/DataDictionaryBuilderImpl.java - About 2 hrs to fix

    Method classDefinitionToString has 70 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private String classDefinitionToString(final ClassDefinition definition)
    {
        StringBuilder result = null;
        
        if (definition != null)
    Severity: Major
    Found in amp/src/main/java/org/alfresco/extension/bulkimport/util/DataDictionaryBuilderImpl.java - About 2 hrs to fix

      Avoid deeply nested control flow statements.
      Open

                              for (ConstraintDefinition propertyConstraint : propertyConstraints)
                        {
                            result.append(propertyConstraint.getName().toPrefixString());
                            result.append(", ");
                        }
      Severity: Major
      Found in amp/src/main/java/org/alfresco/extension/bulkimport/util/DataDictionaryBuilderImpl.java - About 45 mins to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                        if (model.aspects != null && model.aspects.size() > 0)
                {
                    for (AspectDefinition aspect : model.aspects)
                    {
                        result.append(classDefinitionToString(aspect));
        Severity: Minor
        Found in amp/src/main/java/org/alfresco/extension/bulkimport/util/DataDictionaryBuilderImpl.java and 1 other location - About 45 mins to fix
        amp/src/main/java/org/alfresco/extension/bulkimport/util/DataDictionaryBuilderImpl.java on lines 155..165

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                        if (model.types != null && model.types.size() > 0)
                {
                    for (TypeDefinition type : model.types)
                    {
                        result.append(classDefinitionToString(type));
        Severity: Minor
        Found in amp/src/main/java/org/alfresco/extension/bulkimport/util/DataDictionaryBuilderImpl.java and 1 other location - About 45 mins to fix
        amp/src/main/java/org/alfresco/extension/bulkimport/util/DataDictionaryBuilderImpl.java on lines 168..178

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status