Sign upLogin

poisa/Settings

View on GitHub
Star
src/SettingsServiceProvider.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid unused parameters such as '$app'.
Open

        $this->app->singleton(Settings::class, function ($app) {
Severity: Minor
Found in src/SettingsServiceProvider.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Call to undeclared method \Poisa\Settings\SettingsServiceProvider::mergeConfigFrom
Open

        $this->mergeConfigFrom($configFile, 'settings');
Severity: Critical
Found in src/SettingsServiceProvider.php by phan

Call to undeclared method \Poisa\Settings\SettingsServiceProvider::commands
Open

            $this->commands([
Severity: Critical
Found in src/SettingsServiceProvider.php by phan

Call to undeclared function \config_path()
Open

        $this->publishes([$configFile => config_path('settings.php')]);
Severity: Critical
Found in src/SettingsServiceProvider.php by phan

Class extends undeclared class \Illuminate\Support\ServiceProvider
Open

class SettingsServiceProvider extends ServiceProvider
Severity: Critical
Found in src/SettingsServiceProvider.php by phan

Call to undeclared method \Poisa\Settings\SettingsServiceProvider::publishes
Open

        $this->publishes([$configFile => config_path('settings.php')]);
Severity: Critical
Found in src/SettingsServiceProvider.php by phan

Reference to undeclared property \Poisa\Settings\SettingsServiceProvider->app
Open

        $this->app->singleton(Settings::class, function ($app) {
Severity: Minor
Found in src/SettingsServiceProvider.php by phan

Call to undeclared function \config()
Open

        if (config('settings.automatic_migrations')) {
Severity: Critical
Found in src/SettingsServiceProvider.php by phan

Call to undeclared method \Poisa\Settings\SettingsServiceProvider::loadMigrationsFrom
Open

            $this->loadMigrationsFrom($migrationPath);
Severity: Critical
Found in src/SettingsServiceProvider.php by phan

Reference to undeclared property \Poisa\Settings\SettingsServiceProvider->app
Open

        if ($this->app->runningInConsole()) {
Severity: Minor
Found in src/SettingsServiceProvider.php by phan

Remove the unused function parameter "$app".
Open

        $this->app->singleton(Settings::class, function ($app) {
Severity: Major
Found in src/SettingsServiceProvider.php by sonar-php

Unused parameters are misleading. Whatever the value passed to such parameters is, the behavior will be the same.

Noncompliant Code Example

function doSomething($a, $b) { // "$a" is unused
  return compute($b);
}

Compliant Solution

function doSomething($b) {
  return compute($b);
}

Exceptions

Functions in classes that override a class or implement interfaces are ignored.

class C extends B {

  function doSomething($a, $b) {     // no issue reported on $b
    compute($a);
  }

}

See

  • MISRA C++:2008, 0-1-11 - There shall be no unused parameters (named or unnamed) in nonvirtual functions.
  • MISRA C:2012, 2.7 - There should be no unused parameters in functions
  • CERT, MSC12-C. - Detect and remove code that has no effect or is never executed
  • CERT, MSC12-CPP. - Detect and remove code that has no effect

There are no issues that match your filters.

Category
Status