polkadot-js/api

View on GitHub
packages/rpc-provider/src/substrate-connect/index.spec.ts

Summary

Maintainability
D
1 day
Test Coverage

File index.spec.ts has 477 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// Copyright 2017-2024 @polkadot/rpc-provider authors & contributors
// SPDX-License-Identifier: Apache-2.0

/// <reference types="@polkadot/dev-test/globals.d.ts" />

Severity: Minor
Found in packages/rpc-provider/src/substrate-connect/index.spec.ts - About 7 hrs to fix

    Function getFakeChain has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function getFakeChain (spec: string, callback: Sc.JsonRpcCallback): MockChain {
      const _receivedRequests: string[] = [];
      let _isTerminated = false;
    
      let terminateInterceptor = Function.prototype;
    Severity: Minor
    Found in packages/rpc-provider/src/substrate-connect/index.spec.ts - About 1 hr to fix

      Function getFakeClient has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function getFakeClient () {
        const chains: MockChain[] = [];
        let addChainInterceptor: Promise<void> = Promise.resolve();
        let addWellKnownChainInterceptor: Promise<void> = Promise.resolve();
      
      
      Severity: Minor
      Found in packages/rpc-provider/src/substrate-connect/index.spec.ts - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            addChain: (chainSpec: string, cb: Sc.JsonRpcCallback): Promise<MockChain> =>
              addChainInterceptor.then(() => {
                const result = getFakeChain(chainSpec, cb);
        
                chains.push(result);
        Severity: Major
        Found in packages/rpc-provider/src/substrate-connect/index.spec.ts and 1 other location - About 2 hrs to fix
        packages/rpc-provider/src/substrate-connect/index.spec.ts on lines 144..154

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 75.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            addWellKnownChain: (
              wellKnownChain: string,
              cb: Sc.JsonRpcCallback
            ): Promise<MockChain> =>
              addWellKnownChainInterceptor.then(() => {
        Severity: Major
        Found in packages/rpc-provider/src/substrate-connect/index.spec.ts and 1 other location - About 2 hrs to fix
        packages/rpc-provider/src/substrate-connect/index.spec.ts on lines 136..143

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 75.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status