Sign upLogin

polkadot-js/api

View on GitHub
Star
packages/types/src/interfaces/assets/types.ts

Summary

Maintainability
C
7 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export interface AssetDetails extends Struct {
  readonly owner: AccountId;
  readonly issuer: AccountId;
  readonly admin: AccountId;
  readonly freezer: AccountId;
Severity: Major
Found in packages/types/src/interfaces/assets/types.ts and 1 other location - About 4 hrs to fix
packages/types/src/interfaces/eth/types.ts on lines 30..43

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 125.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 18 locations. Consider refactoring.
Open

export interface AssetMetadata extends Struct {
  readonly deposit: TAssetDepositBalance;
  readonly name: Bytes;
  readonly symbol: Bytes;
  readonly decimals: u8;
Severity: Major
Found in packages/types/src/interfaces/assets/types.ts and 17 other locations - About 1 hr to fix
packages/types/src/interfaces/babe/types.ts on lines 137..143
packages/types/src/interfaces/bridges/types.ts on lines 120..126
packages/types/src/interfaces/contracts/types.ts on lines 73..79
packages/types/src/interfaces/contracts/types.ts on lines 132..138
packages/types/src/interfaces/contracts/types.ts on lines 150..156
packages/types/src/interfaces/contracts/types.ts on lines 173..179
packages/types/src/interfaces/contracts/types.ts on lines 462..468
packages/types/src/interfaces/contracts/types.ts on lines 510..516
packages/types/src/interfaces/democracy/types.ts on lines 111..117
packages/types/src/interfaces/democracy/types.ts on lines 136..142
packages/types/src/interfaces/grandpa/types.ts on lines 132..138
packages/types/src/interfaces/grandpa/types.ts on lines 172..178
packages/types/src/interfaces/imOnline/types.ts on lines 16..22
packages/types/src/interfaces/purchase/types.ts on lines 8..14
packages/types/src/interfaces/system/types.ts on lines 39..45
packages/types/src/interfaces/system/types.ts on lines 360..366
packages/types/src/interfaces/xcm/types.ts on lines 515..521

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

export interface AssetDestroyWitness extends Struct {
  readonly accounts: Compact<u32>;
  readonly sufficients: Compact<u32>;
  readonly approvals: Compact<u32>;
}
Severity: Major
Found in packages/types/src/interfaces/assets/types.ts and 4 other locations - About 1 hr to fix
packages/types/src/interfaces/babe/types.ts on lines 71..75
packages/types/src/interfaces/staking/types.ts on lines 159..163
packages/types/src/interfaces/system/types.ts on lines 332..336
packages/types/src/interfaces/uniques/types.ts on lines 38..42

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status