Sign upLogin

polkadot-js/api

View on GitHub
Star
packages/types/src/interfaces/balances/types.ts

Summary

Maintainability
A
3 hrs
Test Coverage

Similar blocks of code found in 16 locations. Consider refactoring.
Open

export interface Reasons extends Enum {
  readonly isFee: boolean;
  readonly isMisc: boolean;
  readonly isAll: boolean;
  readonly type: 'Fee' | 'Misc' | 'All';
Severity: Major
Found in packages/types/src/interfaces/balances/types.ts and 15 other locations - About 1 hr to fix
packages/types/src/interfaces/babe/types.ts on lines 10..15
packages/types/src/interfaces/bridges/types.ts on lines 102..107
packages/types/src/interfaces/contractsAbi/types.ts on lines 107..112
packages/types/src/interfaces/metadata/types.ts on lines 505..510
packages/types/src/interfaces/parachains/types.ts on lines 539..544
packages/types/src/interfaces/parachains/types.ts on lines 573..578
packages/types/src/interfaces/society/types.ts on lines 25..30
packages/types/src/interfaces/society/types.ts on lines 33..38
packages/types/src/interfaces/staking/types.ts on lines 95..100
packages/types/src/interfaces/statement/types.ts on lines 7..12
packages/types/src/interfaces/statement/types.ts on lines 15..20
packages/types/src/interfaces/system/types.ts on lines 64..69
packages/types/src/interfaces/system/types.ts on lines 103..108
packages/types/src/interfaces/txqueue/types.ts on lines 9..14
packages/types/src/interfaces/xcm/types.ts on lines 910..915

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 20 locations. Consider refactoring.
Open

export interface AccountData extends Struct {
  readonly free: Balance;
  readonly reserved: Balance;
  readonly miscFrozen: Balance;
  readonly feeFrozen: Balance;
Severity: Major
Found in packages/types/src/interfaces/balances/types.ts and 19 other locations - About 55 mins to fix
packages/types/src/interfaces/babe/types.ts on lines 30..35
packages/types/src/interfaces/babe/types.ts on lines 129..134
packages/types/src/interfaces/babe/types.ts on lines 159..164
packages/types/src/interfaces/balances/types.ts on lines 23..28
packages/types/src/interfaces/bridges/types.ts on lines 60..65
packages/types/src/interfaces/contractsAbi/types.ts on lines 183..188
packages/types/src/interfaces/contractsAbi/types.ts on lines 374..379
packages/types/src/interfaces/democracy/types.ts on lines 103..108
packages/types/src/interfaces/elections/types.ts on lines 37..42
packages/types/src/interfaces/gilt/types.ts on lines 8..13
packages/types/src/interfaces/gilt/types.ts on lines 16..21
packages/types/src/interfaces/imOnline/types.ts on lines 25..30
packages/types/src/interfaces/parachains/types.ts on lines 211..216
packages/types/src/interfaces/parachains/types.ts on lines 247..252
packages/types/src/interfaces/parachains/types.ts on lines 672..677
packages/types/src/interfaces/parachains/types.ts on lines 680..685
packages/types/src/interfaces/runtime/types.ts on lines 373..378
packages/types/src/interfaces/staking/types.ts on lines 269..274
packages/types/src/interfaces/system/types.ts on lines 14..19

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 20 locations. Consider refactoring.
Open

export interface BalanceLockTo212 extends Struct {
  readonly id: LockIdentifier;
  readonly amount: Balance;
  readonly until: BlockNumber;
  readonly reasons: WithdrawReasons;
Severity: Major
Found in packages/types/src/interfaces/balances/types.ts and 19 other locations - About 55 mins to fix
packages/types/src/interfaces/babe/types.ts on lines 30..35
packages/types/src/interfaces/babe/types.ts on lines 129..134
packages/types/src/interfaces/babe/types.ts on lines 159..164
packages/types/src/interfaces/balances/types.ts on lines 8..13
packages/types/src/interfaces/bridges/types.ts on lines 60..65
packages/types/src/interfaces/contractsAbi/types.ts on lines 183..188
packages/types/src/interfaces/contractsAbi/types.ts on lines 374..379
packages/types/src/interfaces/democracy/types.ts on lines 103..108
packages/types/src/interfaces/elections/types.ts on lines 37..42
packages/types/src/interfaces/gilt/types.ts on lines 8..13
packages/types/src/interfaces/gilt/types.ts on lines 16..21
packages/types/src/interfaces/imOnline/types.ts on lines 25..30
packages/types/src/interfaces/parachains/types.ts on lines 211..216
packages/types/src/interfaces/parachains/types.ts on lines 247..252
packages/types/src/interfaces/parachains/types.ts on lines 672..677
packages/types/src/interfaces/parachains/types.ts on lines 680..685
packages/types/src/interfaces/runtime/types.ts on lines 373..378
packages/types/src/interfaces/staking/types.ts on lines 269..274
packages/types/src/interfaces/system/types.ts on lines 14..19

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 18 locations. Consider refactoring.
Open

export interface BalanceStatus extends Enum {
  readonly isFree: boolean;
  readonly isReserved: boolean;
  readonly type: 'Free' | 'Reserved';
}
Severity: Major
Found in packages/types/src/interfaces/balances/types.ts and 17 other locations - About 30 mins to fix
packages/types/src/interfaces/bridges/types.ts on lines 44..48
packages/types/src/interfaces/nompools/types.ts on lines 7..11
packages/types/src/interfaces/parachains/types.ts on lines 240..244
packages/types/src/interfaces/parachains/types.ts on lines 255..259
packages/types/src/interfaces/parachains/types.ts on lines 641..645
packages/types/src/interfaces/parachains/types.ts on lines 688..692
packages/types/src/interfaces/parachains/types.ts on lines 695..699
packages/types/src/interfaces/parachains/types.ts on lines 749..753
packages/types/src/interfaces/parachains/types.ts on lines 763..767
packages/types/src/interfaces/parachains/types.ts on lines 806..810
packages/types/src/interfaces/parachains/types.ts on lines 896..900
packages/types/src/interfaces/runtime/types.ts on lines 122..126
packages/types/src/interfaces/runtime/types.ts on lines 271..275
packages/types/src/interfaces/system/types.ts on lines 444..448
packages/types/src/interfaces/xcm/types.ts on lines 119..123
packages/types/src/interfaces/xcm/types.ts on lines 478..482
packages/types/src/interfaces/xcm/types.ts on lines 636..640

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status