Sign upLogin

polkadot-js/api

View on GitHub
Star
packages/types/src/interfaces/bridges/types.ts

Summary

Maintainability
B
6 hrs
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

export interface MessagesProofOf extends Struct {
  readonly bridgedHeaderHash: BridgedBlockHash;
  readonly storageProof: Vec<Bytes>;
  readonly lane: LaneId;
  readonly noncesStart: MessageNonce;
Severity: Major
Found in packages/types/src/interfaces/bridges/types.ts and 2 other locations - About 1 hr to fix
packages/types/src/interfaces/runtime/types.ts on lines 180..186
packages/types/src/interfaces/state/types.ts on lines 35..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 18 locations. Consider refactoring.
Open

export interface OutboundPayload extends Struct {
  readonly specVersion: u32;
  readonly weight: Weight;
  readonly origin: CallOrigin;
  readonly dispatchFeePayment: DispatchFeePayment;
Severity: Major
Found in packages/types/src/interfaces/bridges/types.ts and 17 other locations - About 1 hr to fix
packages/types/src/interfaces/assets/types.ts on lines 50..56
packages/types/src/interfaces/babe/types.ts on lines 137..143
packages/types/src/interfaces/contracts/types.ts on lines 73..79
packages/types/src/interfaces/contracts/types.ts on lines 132..138
packages/types/src/interfaces/contracts/types.ts on lines 150..156
packages/types/src/interfaces/contracts/types.ts on lines 173..179
packages/types/src/interfaces/contracts/types.ts on lines 462..468
packages/types/src/interfaces/contracts/types.ts on lines 510..516
packages/types/src/interfaces/democracy/types.ts on lines 111..117
packages/types/src/interfaces/democracy/types.ts on lines 136..142
packages/types/src/interfaces/grandpa/types.ts on lines 132..138
packages/types/src/interfaces/grandpa/types.ts on lines 172..178
packages/types/src/interfaces/imOnline/types.ts on lines 16..22
packages/types/src/interfaces/purchase/types.ts on lines 8..14
packages/types/src/interfaces/system/types.ts on lines 39..45
packages/types/src/interfaces/system/types.ts on lines 360..366
packages/types/src/interfaces/xcm/types.ts on lines 515..521

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

export interface OperatingMode extends Enum {
  readonly isNormal: boolean;
  readonly isRejectingOutboundMessages: boolean;
  readonly isHalted: boolean;
  readonly type: 'Normal' | 'RejectingOutboundMessages' | 'Halted';
Severity: Major
Found in packages/types/src/interfaces/bridges/types.ts and 15 other locations - About 1 hr to fix
packages/types/src/interfaces/babe/types.ts on lines 10..15
packages/types/src/interfaces/balances/types.ts on lines 38..43
packages/types/src/interfaces/contractsAbi/types.ts on lines 107..112
packages/types/src/interfaces/metadata/types.ts on lines 505..510
packages/types/src/interfaces/parachains/types.ts on lines 539..544
packages/types/src/interfaces/parachains/types.ts on lines 573..578
packages/types/src/interfaces/society/types.ts on lines 25..30
packages/types/src/interfaces/society/types.ts on lines 33..38
packages/types/src/interfaces/staking/types.ts on lines 95..100
packages/types/src/interfaces/statement/types.ts on lines 7..12
packages/types/src/interfaces/statement/types.ts on lines 15..20
packages/types/src/interfaces/system/types.ts on lines 64..69
packages/types/src/interfaces/system/types.ts on lines 103..108
packages/types/src/interfaces/txqueue/types.ts on lines 9..14
packages/types/src/interfaces/xcm/types.ts on lines 910..915

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 20 locations. Consider refactoring.
Open

export interface InitializationData extends Struct {
  readonly header: Header;
  readonly authorityList: AuthorityList;
  readonly setId: SetId;
  readonly isHalted: bool;
Severity: Major
Found in packages/types/src/interfaces/bridges/types.ts and 19 other locations - About 55 mins to fix
packages/types/src/interfaces/babe/types.ts on lines 30..35
packages/types/src/interfaces/babe/types.ts on lines 129..134
packages/types/src/interfaces/babe/types.ts on lines 159..164
packages/types/src/interfaces/balances/types.ts on lines 8..13
packages/types/src/interfaces/balances/types.ts on lines 23..28
packages/types/src/interfaces/contractsAbi/types.ts on lines 183..188
packages/types/src/interfaces/contractsAbi/types.ts on lines 374..379
packages/types/src/interfaces/democracy/types.ts on lines 103..108
packages/types/src/interfaces/elections/types.ts on lines 37..42
packages/types/src/interfaces/gilt/types.ts on lines 8..13
packages/types/src/interfaces/gilt/types.ts on lines 16..21
packages/types/src/interfaces/imOnline/types.ts on lines 25..30
packages/types/src/interfaces/parachains/types.ts on lines 211..216
packages/types/src/interfaces/parachains/types.ts on lines 247..252
packages/types/src/interfaces/parachains/types.ts on lines 672..677
packages/types/src/interfaces/parachains/types.ts on lines 680..685
packages/types/src/interfaces/runtime/types.ts on lines 373..378
packages/types/src/interfaces/staking/types.ts on lines 269..274
packages/types/src/interfaces/system/types.ts on lines 14..19

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

export interface MessagesDeliveryProofOf extends Struct {
  readonly bridgedHeaderHash: BlockHash;
  readonly storageProof: Vec<Bytes>;
  readonly lane: LaneId;
}
Severity: Major
Found in packages/types/src/interfaces/bridges/types.ts and 6 other locations - About 45 mins to fix
packages/types/src/interfaces/contractsAbi/types.ts on lines 314..318
packages/types/src/interfaces/evm/types.ts on lines 48..52
packages/types/src/interfaces/parachains/types.ts on lines 68..72
packages/types/src/interfaces/parachains/types.ts on lines 90..94
packages/types/src/interfaces/scaleInfo/types.ts on lines 21..25
packages/types/src/interfaces/session/types.ts on lines 22..26

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 18 locations. Consider refactoring.
Open

export interface DispatchFeePayment extends Enum {
  readonly isAtSourceChain: boolean;
  readonly isAtTargetChain: boolean;
  readonly type: 'AtSourceChain' | 'AtTargetChain';
}
Severity: Major
Found in packages/types/src/interfaces/bridges/types.ts and 17 other locations - About 30 mins to fix
packages/types/src/interfaces/balances/types.ts on lines 31..35
packages/types/src/interfaces/nompools/types.ts on lines 7..11
packages/types/src/interfaces/parachains/types.ts on lines 240..244
packages/types/src/interfaces/parachains/types.ts on lines 255..259
packages/types/src/interfaces/parachains/types.ts on lines 641..645
packages/types/src/interfaces/parachains/types.ts on lines 688..692
packages/types/src/interfaces/parachains/types.ts on lines 695..699
packages/types/src/interfaces/parachains/types.ts on lines 749..753
packages/types/src/interfaces/parachains/types.ts on lines 763..767
packages/types/src/interfaces/parachains/types.ts on lines 806..810
packages/types/src/interfaces/parachains/types.ts on lines 896..900
packages/types/src/interfaces/runtime/types.ts on lines 122..126
packages/types/src/interfaces/runtime/types.ts on lines 271..275
packages/types/src/interfaces/system/types.ts on lines 444..448
packages/types/src/interfaces/xcm/types.ts on lines 119..123
packages/types/src/interfaces/xcm/types.ts on lines 478..482
packages/types/src/interfaces/xcm/types.ts on lines 636..640

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status