Sign upLogin

polkadot-js/api

View on GitHub
Star
packages/types/src/interfaces/elections/types.ts

Summary

Maintainability
A
3 hrs
Test Coverage

Similar blocks of code found in 12 locations. Consider refactoring.
Open

export interface DefunctVoter extends Struct {
  readonly who: AccountId;
  readonly voteCount: Compact<u32>;
  readonly candidateCount: Compact<u32>;
}
Severity: Major
Found in packages/types/src/interfaces/elections/types.ts and 11 other locations - About 1 hr to fix
packages/types/src/interfaces/attestations/types.ts on lines 10..14
packages/types/src/interfaces/contractsAbi/types.ts on lines 153..157
packages/types/src/interfaces/contractsAbi/types.ts on lines 160..164
packages/types/src/interfaces/contractsAbi/types.ts on lines 167..171
packages/types/src/interfaces/eth/types.ts on lines 9..13
packages/types/src/interfaces/eth/types.ts on lines 16..20
packages/types/src/interfaces/eth/types.ts on lines 23..27
packages/types/src/interfaces/eth/types.ts on lines 84..88
packages/types/src/interfaces/metadata/types.ts on lines 74..78
packages/types/src/interfaces/metadata/types.ts on lines 165..169
packages/types/src/interfaces/metadata/types.ts on lines 405..409

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

export interface Renouncing extends Enum {
  readonly isMember: boolean;
  readonly isRunnerUp: boolean;
  readonly isCandidate: boolean;
  readonly asCandidate: Compact<u32>;
Severity: Major
Found in packages/types/src/interfaces/elections/types.ts and 1 other location - About 1 hr to fix
packages/types-augment/src/lookup/types-substrate.ts on lines 3143..3149

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 20 locations. Consider refactoring.
Open

export interface VoterInfo extends Struct {
  readonly lastActive: VoteIndex;
  readonly lastWin: VoteIndex;
  readonly pot: Balance;
  readonly stake: Balance;
Severity: Major
Found in packages/types/src/interfaces/elections/types.ts and 19 other locations - About 55 mins to fix
packages/types/src/interfaces/babe/types.ts on lines 30..35
packages/types/src/interfaces/babe/types.ts on lines 129..134
packages/types/src/interfaces/babe/types.ts on lines 159..164
packages/types/src/interfaces/balances/types.ts on lines 8..13
packages/types/src/interfaces/balances/types.ts on lines 23..28
packages/types/src/interfaces/bridges/types.ts on lines 60..65
packages/types/src/interfaces/contractsAbi/types.ts on lines 183..188
packages/types/src/interfaces/contractsAbi/types.ts on lines 374..379
packages/types/src/interfaces/democracy/types.ts on lines 103..108
packages/types/src/interfaces/gilt/types.ts on lines 8..13
packages/types/src/interfaces/gilt/types.ts on lines 16..21
packages/types/src/interfaces/imOnline/types.ts on lines 25..30
packages/types/src/interfaces/parachains/types.ts on lines 211..216
packages/types/src/interfaces/parachains/types.ts on lines 247..252
packages/types/src/interfaces/parachains/types.ts on lines 672..677
packages/types/src/interfaces/parachains/types.ts on lines 680..685
packages/types/src/interfaces/runtime/types.ts on lines 373..378
packages/types/src/interfaces/staking/types.ts on lines 269..274
packages/types/src/interfaces/system/types.ts on lines 14..19

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export interface VoteThreshold extends Enum {
  readonly isSuperMajorityApprove: boolean;
  readonly isSuperMajorityAgainst: boolean;
  readonly isSimpleMajority: boolean;
  readonly type: 'SuperMajorityApprove' | 'SuperMajorityAgainst' | 'SimpleMajority';
Severity: Minor
Found in packages/types/src/interfaces/elections/types.ts and 1 other location - About 55 mins to fix
packages/types/src/interfaces/evm/types.ts on lines 119..124

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status