Sign upLogin

polkadot-js/api

View on GitHub
Star
packages/types/src/interfaces/grandpa/types.ts

Summary

Maintainability
C
1 day
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

export interface AuthoritySet extends Struct {
  readonly currentAuthorities: AuthorityList;
  readonly setId: u64;
  readonly pendingStandardChanges: ForkTreePendingChange;
  readonly pendingForcedChanges: Vec<PendingChange>;
Severity: Major
Found in packages/types/src/interfaces/grandpa/types.ts and 2 other locations - About 1 hr to fix
packages/types/src/interfaces/contractsAbi/types.ts on lines 382..388
packages/types/src/interfaces/parachains/types.ts on lines 887..893

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 19 locations. Consider refactoring.
Open

export interface GrandpaEquivocation extends Enum {
  readonly isPrevote: boolean;
  readonly asPrevote: GrandpaEquivocationValue;
  readonly isPrecommit: boolean;
  readonly asPrecommit: GrandpaEquivocationValue;
Severity: Major
Found in packages/types/src/interfaces/grandpa/types.ts and 18 other locations - About 1 hr to fix
packages/types/src/interfaces/author/types.ts on lines 8..14
packages/types/src/interfaces/babe/types.ts on lines 167..173
packages/types/src/interfaces/contracts/types.ts on lines 25..31
packages/types/src/interfaces/contracts/types.ts on lines 141..147
packages/types/src/interfaces/contracts/types.ts on lines 522..528
packages/types/src/interfaces/democracy/types.ts on lines 10..16
packages/types/src/interfaces/democracy/types.ts on lines 49..55
packages/types/src/interfaces/democracy/types.ts on lines 76..82
packages/types/src/interfaces/democracy/types.ts on lines 88..94
packages/types/src/interfaces/democracy/types.ts on lines 127..133
packages/types/src/interfaces/eth/types.ts on lines 367..373
packages/types/src/interfaces/eth/types.ts on lines 427..433
packages/types/src/interfaces/parachains/types.ts on lines 103..109
packages/types/src/interfaces/parachains/types.ts on lines 270..276
packages/types/src/interfaces/state/types.ts on lines 111..117
packages/types/src/interfaces/system/types.ts on lines 451..457
packages/types/src/interfaces/xcm/types.ts on lines 352..358
packages/types/src/interfaces/xcm/types.ts on lines 666..672

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 18 locations. Consider refactoring.
Open

export interface PendingChange extends Struct {
  readonly nextAuthorities: AuthorityList;
  readonly delay: BlockNumber;
  readonly canonHeight: BlockNumber;
  readonly canonHash: BlockHash;
Severity: Major
Found in packages/types/src/interfaces/grandpa/types.ts and 17 other locations - About 1 hr to fix
packages/types/src/interfaces/assets/types.ts on lines 50..56
packages/types/src/interfaces/babe/types.ts on lines 137..143
packages/types/src/interfaces/bridges/types.ts on lines 120..126
packages/types/src/interfaces/contracts/types.ts on lines 73..79
packages/types/src/interfaces/contracts/types.ts on lines 132..138
packages/types/src/interfaces/contracts/types.ts on lines 150..156
packages/types/src/interfaces/contracts/types.ts on lines 173..179
packages/types/src/interfaces/contracts/types.ts on lines 462..468
packages/types/src/interfaces/contracts/types.ts on lines 510..516
packages/types/src/interfaces/democracy/types.ts on lines 111..117
packages/types/src/interfaces/democracy/types.ts on lines 136..142
packages/types/src/interfaces/grandpa/types.ts on lines 172..178
packages/types/src/interfaces/imOnline/types.ts on lines 16..22
packages/types/src/interfaces/purchase/types.ts on lines 8..14
packages/types/src/interfaces/system/types.ts on lines 39..45
packages/types/src/interfaces/system/types.ts on lines 360..366
packages/types/src/interfaces/xcm/types.ts on lines 515..521

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 18 locations. Consider refactoring.
Open

export interface RoundState extends Struct {
  readonly round: u32;
  readonly totalWeight: u32;
  readonly thresholdWeight: u32;
  readonly prevotes: Prevotes;
Severity: Major
Found in packages/types/src/interfaces/grandpa/types.ts and 17 other locations - About 1 hr to fix
packages/types/src/interfaces/assets/types.ts on lines 50..56
packages/types/src/interfaces/babe/types.ts on lines 137..143
packages/types/src/interfaces/bridges/types.ts on lines 120..126
packages/types/src/interfaces/contracts/types.ts on lines 73..79
packages/types/src/interfaces/contracts/types.ts on lines 132..138
packages/types/src/interfaces/contracts/types.ts on lines 150..156
packages/types/src/interfaces/contracts/types.ts on lines 173..179
packages/types/src/interfaces/contracts/types.ts on lines 462..468
packages/types/src/interfaces/contracts/types.ts on lines 510..516
packages/types/src/interfaces/democracy/types.ts on lines 111..117
packages/types/src/interfaces/democracy/types.ts on lines 136..142
packages/types/src/interfaces/grandpa/types.ts on lines 132..138
packages/types/src/interfaces/imOnline/types.ts on lines 16..22
packages/types/src/interfaces/purchase/types.ts on lines 8..14
packages/types/src/interfaces/system/types.ts on lines 39..45
packages/types/src/interfaces/system/types.ts on lines 360..366
packages/types/src/interfaces/xcm/types.ts on lines 515..521

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

export interface ForkTreePendingChangeNode extends Struct {
  readonly hash: BlockHash;
  readonly number: BlockNumber;
  readonly data: PendingChange;
  readonly children: Vec<ForkTreePendingChangeNode>;
Severity: Major
Found in packages/types/src/interfaces/grandpa/types.ts and 12 other locations - About 1 hr to fix
packages/types/src/interfaces/beefy/types.ts on lines 25..30
packages/types/src/interfaces/benchmark/types.ts on lines 8..13
packages/types/src/interfaces/contractsAbi/types.ts on lines 134..139
packages/types/src/interfaces/contractsAbi/types.ts on lines 142..147
packages/types/src/interfaces/eth/types.ts on lines 405..410
packages/types/src/interfaces/evm/types.ts on lines 14..19
packages/types/src/interfaces/evm/types.ts on lines 31..36
packages/types/src/interfaces/metadata/types.ts on lines 253..258
packages/types/src/interfaces/metadata/types.ts on lines 334..339
packages/types/src/interfaces/parachains/types.ts on lines 262..267
packages/types/src/interfaces/staking/types.ts on lines 287..292
packages/types/src/interfaces/utility/types.ts on lines 8..13

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

export interface DelayKind extends Enum {
  readonly isFinalized: boolean;
  readonly isBest: boolean;
  readonly asBest: DelayKindBest;
  readonly type: 'Finalized' | 'Best';
Severity: Major
Found in packages/types/src/interfaces/grandpa/types.ts and 6 other locations - About 55 mins to fix
packages/types/src/interfaces/babe/types.ts on lines 84..89
packages/types/src/interfaces/beefy/types.ts on lines 61..66
packages/types/src/interfaces/eth/types.ts on lines 294..299
packages/types/src/interfaces/genericAsset/types.ts on lines 14..19
packages/types/src/interfaces/parachains/types.ts on lines 735..740
packages/types/src/interfaces/staking/types.ts on lines 130..135

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 17 locations. Consider refactoring.
Open

export interface GrandpaCommit extends Struct {
  readonly targetHash: BlockHash;
  readonly targetNumber: BlockNumber;
  readonly precommits: Vec<GrandpaSignedPrecommit>;
}
Severity: Major
Found in packages/types/src/interfaces/grandpa/types.ts and 16 other locations - About 45 mins to fix
packages/types/src/interfaces/benchmark/types.ts on lines 25..29
packages/types/src/interfaces/contracts/types.ts on lines 34..38
packages/types/src/interfaces/contracts/types.ts on lines 356..360
packages/types/src/interfaces/eth/types.ts on lines 278..282
packages/types/src/interfaces/grandpa/types.ts on lines 97..101
packages/types/src/interfaces/grandpa/types.ts on lines 165..169
packages/types/src/interfaces/metadata/types.ts on lines 96..100
packages/types/src/interfaces/metadata/types.ts on lines 128..132
packages/types/src/interfaces/parachains/types.ts on lines 490..494
packages/types/src/interfaces/parachains/types.ts on lines 930..934
packages/types/src/interfaces/recovery/types.ts on lines 8..12
packages/types/src/interfaces/staking/types.ts on lines 295..299
packages/types/src/interfaces/state/types.ts on lines 23..27
packages/types/src/interfaces/state/types.ts on lines 74..78
packages/types/src/interfaces/system/types.ts on lines 258..262
packages/types/src/interfaces/system/types.ts on lines 420..424

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 17 locations. Consider refactoring.
Open

export interface ReportedRoundStates extends Struct {
  readonly setId: u32;
  readonly best: RoundState;
  readonly background: Vec<RoundState>;
}
Severity: Major
Found in packages/types/src/interfaces/grandpa/types.ts and 16 other locations - About 45 mins to fix
packages/types/src/interfaces/benchmark/types.ts on lines 25..29
packages/types/src/interfaces/contracts/types.ts on lines 34..38
packages/types/src/interfaces/contracts/types.ts on lines 356..360
packages/types/src/interfaces/eth/types.ts on lines 278..282
packages/types/src/interfaces/grandpa/types.ts on lines 67..71
packages/types/src/interfaces/grandpa/types.ts on lines 97..101
packages/types/src/interfaces/metadata/types.ts on lines 96..100
packages/types/src/interfaces/metadata/types.ts on lines 128..132
packages/types/src/interfaces/parachains/types.ts on lines 490..494
packages/types/src/interfaces/parachains/types.ts on lines 930..934
packages/types/src/interfaces/recovery/types.ts on lines 8..12
packages/types/src/interfaces/staking/types.ts on lines 295..299
packages/types/src/interfaces/state/types.ts on lines 23..27
packages/types/src/interfaces/state/types.ts on lines 74..78
packages/types/src/interfaces/system/types.ts on lines 258..262
packages/types/src/interfaces/system/types.ts on lines 420..424

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 17 locations. Consider refactoring.
Open

export interface GrandpaJustification extends Struct {
  readonly round: u64;
  readonly commit: GrandpaCommit;
  readonly votesAncestries: Vec<Header>;
}
Severity: Major
Found in packages/types/src/interfaces/grandpa/types.ts and 16 other locations - About 45 mins to fix
packages/types/src/interfaces/benchmark/types.ts on lines 25..29
packages/types/src/interfaces/contracts/types.ts on lines 34..38
packages/types/src/interfaces/contracts/types.ts on lines 356..360
packages/types/src/interfaces/eth/types.ts on lines 278..282
packages/types/src/interfaces/grandpa/types.ts on lines 67..71
packages/types/src/interfaces/grandpa/types.ts on lines 165..169
packages/types/src/interfaces/metadata/types.ts on lines 96..100
packages/types/src/interfaces/metadata/types.ts on lines 128..132
packages/types/src/interfaces/parachains/types.ts on lines 490..494
packages/types/src/interfaces/parachains/types.ts on lines 930..934
packages/types/src/interfaces/recovery/types.ts on lines 8..12
packages/types/src/interfaces/staking/types.ts on lines 295..299
packages/types/src/interfaces/state/types.ts on lines 23..27
packages/types/src/interfaces/state/types.ts on lines 74..78
packages/types/src/interfaces/system/types.ts on lines 258..262
packages/types/src/interfaces/system/types.ts on lines 420..424

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

export interface ForkTreePendingChange extends Struct {
  readonly roots: Vec<ForkTreePendingChangeNode>;
  readonly bestFinalizedNumber: Option<BlockNumber>;
}
Severity: Major
Found in packages/types/src/interfaces/grandpa/types.ts and 5 other locations - About 35 mins to fix
packages/types/src/interfaces/parachains/types.ts on lines 635..638
packages/types/src/interfaces/staking/types.ts on lines 124..127
packages/types/src/interfaces/staking/types.ts on lines 309..312
packages/types/src/interfaces/staking/types.ts on lines 377..380
packages/types/src/interfaces/staking/types.ts on lines 392..395

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status