Sign upLogin

polkadot-js/api

View on GitHub
Star
packages/types/src/interfaces/nompools/types.ts

Summary

Maintainability
A
30 mins
Test Coverage

Similar blocks of code found in 18 locations. Consider refactoring.
Open

export interface NpApiError extends Enum {
  readonly isMemberNotFound: boolean;
  readonly isOverflowInPendingRewards: boolean;
  readonly type: 'MemberNotFound' | 'OverflowInPendingRewards';
}
Severity: Major
Found in packages/types/src/interfaces/nompools/types.ts and 17 other locations - About 30 mins to fix
packages/types/src/interfaces/balances/types.ts on lines 31..35
packages/types/src/interfaces/bridges/types.ts on lines 44..48
packages/types/src/interfaces/parachains/types.ts on lines 240..244
packages/types/src/interfaces/parachains/types.ts on lines 255..259
packages/types/src/interfaces/parachains/types.ts on lines 641..645
packages/types/src/interfaces/parachains/types.ts on lines 688..692
packages/types/src/interfaces/parachains/types.ts on lines 695..699
packages/types/src/interfaces/parachains/types.ts on lines 749..753
packages/types/src/interfaces/parachains/types.ts on lines 763..767
packages/types/src/interfaces/parachains/types.ts on lines 806..810
packages/types/src/interfaces/parachains/types.ts on lines 896..900
packages/types/src/interfaces/runtime/types.ts on lines 122..126
packages/types/src/interfaces/runtime/types.ts on lines 271..275
packages/types/src/interfaces/system/types.ts on lines 444..448
packages/types/src/interfaces/xcm/types.ts on lines 119..123
packages/types/src/interfaces/xcm/types.ts on lines 478..482
packages/types/src/interfaces/xcm/types.ts on lines 636..640

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status