Sign upLogin

polkadot-js/api

View on GitHub
Star
packages/types/src/interfaces/society/types.ts

Summary

Maintainability
A
3 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export interface BidKind extends Enum {
  readonly isDeposit: boolean;
  readonly asDeposit: Balance;
  readonly isVouch: boolean;
  readonly asVouch: ITuple<[AccountId, Balance]>;
Severity: Major
Found in packages/types/src/interfaces/society/types.ts and 1 other location - About 1 hr to fix
packages/types-augment/src/lookup/types-substrate.ts on lines 7648..7654

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

export interface SocietyVote extends Enum {
  readonly isSkeptic: boolean;
  readonly isReject: boolean;
  readonly isApprove: boolean;
  readonly type: 'Skeptic' | 'Reject' | 'Approve';
Severity: Major
Found in packages/types/src/interfaces/society/types.ts and 15 other locations - About 1 hr to fix
packages/types/src/interfaces/babe/types.ts on lines 10..15
packages/types/src/interfaces/balances/types.ts on lines 38..43
packages/types/src/interfaces/bridges/types.ts on lines 102..107
packages/types/src/interfaces/contractsAbi/types.ts on lines 107..112
packages/types/src/interfaces/metadata/types.ts on lines 505..510
packages/types/src/interfaces/parachains/types.ts on lines 539..544
packages/types/src/interfaces/parachains/types.ts on lines 573..578
packages/types/src/interfaces/society/types.ts on lines 25..30
packages/types/src/interfaces/staking/types.ts on lines 95..100
packages/types/src/interfaces/statement/types.ts on lines 7..12
packages/types/src/interfaces/statement/types.ts on lines 15..20
packages/types/src/interfaces/system/types.ts on lines 64..69
packages/types/src/interfaces/system/types.ts on lines 103..108
packages/types/src/interfaces/txqueue/types.ts on lines 9..14
packages/types/src/interfaces/xcm/types.ts on lines 910..915

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 16 locations. Consider refactoring.
Open

export interface SocietyJudgement extends Enum {
  readonly isRebid: boolean;
  readonly isReject: boolean;
  readonly isApprove: boolean;
  readonly type: 'Rebid' | 'Reject' | 'Approve';
Severity: Major
Found in packages/types/src/interfaces/society/types.ts and 15 other locations - About 1 hr to fix
packages/types/src/interfaces/babe/types.ts on lines 10..15
packages/types/src/interfaces/balances/types.ts on lines 38..43
packages/types/src/interfaces/bridges/types.ts on lines 102..107
packages/types/src/interfaces/contractsAbi/types.ts on lines 107..112
packages/types/src/interfaces/metadata/types.ts on lines 505..510
packages/types/src/interfaces/parachains/types.ts on lines 539..544
packages/types/src/interfaces/parachains/types.ts on lines 573..578
packages/types/src/interfaces/society/types.ts on lines 33..38
packages/types/src/interfaces/staking/types.ts on lines 95..100
packages/types/src/interfaces/statement/types.ts on lines 7..12
packages/types/src/interfaces/statement/types.ts on lines 15..20
packages/types/src/interfaces/system/types.ts on lines 64..69
packages/types/src/interfaces/system/types.ts on lines 103..108
packages/types/src/interfaces/txqueue/types.ts on lines 9..14
packages/types/src/interfaces/xcm/types.ts on lines 910..915

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 55.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status