polkadot-js/apps

View on GitHub
packages/page-calendar/src/useScheduled.ts

Summary

Maintainability
C
1 day
Test Coverage

Function useScheduledImpl has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function useScheduledImpl (): EntryInfoTyped[] {
  const { api } = useApi();
  const blockTime = useBlockInterval();
  const bestNumber = useBestNumber();
  const leaseRangeMax = useLeaseRangeMax();
Severity: Major
Found in packages/page-calendar/src/useScheduled.ts - About 2 hrs to fix

    Function createStakingInfo has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function createStakingInfo (bestNumber: BlockNumber, blockTime: BN, sessionInfo: DeriveSessionProgress, unapplied: SlashEntry[], slashDeferDuration?: BlockNumber): [EntryType, EntryInfo[]][] {
      const blocksEra = sessionInfo.eraLength.sub(sessionInfo.eraProgress);
      const blocksSes = sessionInfo.sessionLength.sub(sessionInfo.sessionProgress);
      const slashDuration = slashDeferDuration?.mul(sessionInfo.eraLength);
      const slashEras = slashDuration
    Severity: Minor
    Found in packages/page-calendar/src/useScheduled.ts - About 1 hr to fix

      Function createStakingInfo has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      function createStakingInfo (bestNumber: BlockNumber, blockTime: BN, sessionInfo: DeriveSessionProgress, unapplied: SlashEntry[], slashDeferDuration?: BlockNumber): [EntryType, EntryInfo[]][] {
      Severity: Minor
      Found in packages/page-calendar/src/useScheduled.ts - About 35 mins to fix

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

          useEffect((): void => {
            bestNumber && councilMotions && setState((state) =>
              addFiltered(state, createCouncilMotions(bestNumber, blockTime, councilMotions))
            );
          }, [bestNumber, blockTime, councilMotions]);
        Severity: Major
        Found in packages/page-calendar/src/useScheduled.ts and 3 other locations - About 50 mins to fix
        packages/page-calendar/src/useScheduled.ts on lines 214..218
        packages/page-calendar/src/useScheduled.ts on lines 226..230
        packages/page-calendar/src/useScheduled.ts on lines 232..236

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

          useEffect((): void => {
            bestNumber && scheduled && setState((state) =>
              addFiltered(state, createScheduled(bestNumber, blockTime, scheduled))
            );
          }, [bestNumber, blockTime, scheduled]);
        Severity: Major
        Found in packages/page-calendar/src/useScheduled.ts and 3 other locations - About 50 mins to fix
        packages/page-calendar/src/useScheduled.ts on lines 214..218
        packages/page-calendar/src/useScheduled.ts on lines 220..224
        packages/page-calendar/src/useScheduled.ts on lines 226..230

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

          useEffect((): void => {
            bestNumber && dispatches && setState((state) =>
              addFiltered(state, createDispatches(bestNumber, blockTime, dispatches))
            );
          }, [bestNumber, blockTime, dispatches]);
        Severity: Major
        Found in packages/page-calendar/src/useScheduled.ts and 3 other locations - About 50 mins to fix
        packages/page-calendar/src/useScheduled.ts on lines 220..224
        packages/page-calendar/src/useScheduled.ts on lines 226..230
        packages/page-calendar/src/useScheduled.ts on lines 232..236

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

          useEffect((): void => {
            bestNumber && referendums && setState((state) =>
              addFiltered(state, createReferendums(bestNumber, blockTime, referendums))
            );
          }, [bestNumber, blockTime, referendums]);
        Severity: Major
        Found in packages/page-calendar/src/useScheduled.ts and 3 other locations - About 50 mins to fix
        packages/page-calendar/src/useScheduled.ts on lines 214..218
        packages/page-calendar/src/useScheduled.ts on lines 220..224
        packages/page-calendar/src/useScheduled.ts on lines 232..236

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            ['stakingEra', [{
              ...newDate(blocksEra, blockTime),
              blockNumber: bestNumber.add(blocksEra),
              blocks: blocksEra,
              info: sessionInfo.activeEra.add(BN_ONE)
        Severity: Minor
        Found in packages/page-calendar/src/useScheduled.ts and 1 other location - About 45 mins to fix
        packages/page-calendar/src/useScheduled.ts on lines 129..134

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            ['stakingEpoch', [{
              ...newDate(blocksSes, blockTime),
              blockNumber: bestNumber.add(blocksSes),
              blocks: blocksSes,
              info: sessionInfo.currentIndex.add(BN_ONE)
        Severity: Minor
        Found in packages/page-calendar/src/useScheduled.ts and 1 other location - About 45 mins to fix
        packages/page-calendar/src/useScheduled.ts on lines 135..140

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status