Sign upLogin

polkadot-js/apps

View on GitHub
Star
packages/page-referenda/src/useAccountLocks.ts

Summary

Maintainability
C
1 day
Test Coverage

Function getLocks has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
Open

function getLocks (api: ApiPromise, palletVote: PalletVote, votes: [classId: BN, refIds: BN[], casting: PalletConvictionVotingVoteCasting][], referenda: [BN, PalletReferendaReferendumInfoConvictionVotingTally][]): Lock[] {
  const lockPeriod = api.consts[palletVote].voteLockingPeriod as BN;
  const locks: Lock[] = [];

  for (let i = 0, voteCount = votes.length; i < voteCount; i++) {
Severity: Minor
Found in packages/page-referenda/src/useAccountLocks.ts - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getLocks has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function getLocks (api: ApiPromise, palletVote: PalletVote, votes: [classId: BN, refIds: BN[], casting: PalletConvictionVotingVoteCasting][], referenda: [BN, PalletReferendaReferendumInfoConvictionVotingTally][]): Lock[] {
  const lockPeriod = api.consts[palletVote].voteLockingPeriod as BN;
  const locks: Lock[] = [];

  for (let i = 0, voteCount = votes.length; i < voteCount; i++) {
Severity: Major
Found in packages/page-referenda/src/useAccountLocks.ts - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Open

              if ((tally.isApproved && vote.isAye) || (tally.isRejected && vote.isNay)) {
            convictionIndex = vote.conviction.index;
            locked = vote.conviction.type;
          }
    Severity: Major
    Found in packages/page-referenda/src/useAccountLocks.ts - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

              } else if (accountVote.isSplit) {
          const { aye, nay } = accountVote.asSplit;

          total = aye.add(nay);
        } else if (accountVote.isSplitAbstain) {
      Severity: Major
      Found in packages/page-referenda/src/useAccountLocks.ts - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status