Sign upLogin

polkadot-js/apps

View on GitHub
Star
packages/react-hooks/src/ctx/Queue.tsx

Summary

Maintainability
C
1 day
Test Coverage

Function QueueCtxRoot has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

export function QueueCtxRoot ({ children }: Props): React.ReactElement<Props> {
  const [stqueue, _setStQueue] = useState<QueueStatus[]>(EMPTY_QUEUE_ST);
  const [txqueue, _setTxQueue] = useState<QueueTx[]>(EMPTY_QUEUE_TX);
  const stRef = useRef(stqueue);
  const txRef = useRef(txqueue);
Severity: Minor
Found in packages/react-hooks/src/ctx/Queue.tsx - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function extractEvents has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function extractEvents (result?: SubmittableResult): ActionStatus[] {
  return mergeStatus(
    (result?.events || [])
      // filter events handled globally, or those we are not interested in, these are
      // handled by the global overview, so don't add them here
Severity: Major
Found in packages/react-hooks/src/ctx/Queue.tsx - About 2 hrs to fix

    File Queue.tsx has 256 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // Copyright 2017-2024 @polkadot/react-hooks authors & contributors
// SPDX-License-Identifier: Apache-2.0

import type { SubmittableResult } from '@polkadot/api';
import type { SubmittableExtrinsic } from '@polkadot/api/promise/types';
    Severity: Minor
    Found in packages/react-hooks/src/ctx/Queue.tsx - About 2 hrs to fix

      Function mergeStatus has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function mergeStatus (status: ActionStatusPartial[]): ActionStatus[] {
  let others: ActionStatus | null = null;

  const initial = status
    .reduce((result: StatusCount[], status): StatusCount[] => {
      Severity: Minor
      Found in packages/react-hooks/src/ctx/Queue.tsx - About 1 hr to fix

        Avoid too many return statements within this function.
        Open

                return {
          action: `${section}.${method}`,
          message: EVENT_MESSAGE,
          status: 'event'
        };
        Severity: Major
        Found in packages/react-hooks/src/ctx/Queue.tsx - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            const setTxQueue = useCallback(
    (tx: QueueTx[]): void => {
      txRef.current = tx;
      _setTxQueue(tx);
    },
          Severity: Minor
          Found in packages/react-hooks/src/ctx/Queue.tsx and 1 other location - About 40 mins to fix
          packages/react-hooks/src/ctx/Queue.tsx on lines 166..172

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            const setStQueue = useCallback(
    (st: QueueStatus[]): void => {
      stRef.current = st;
      _setStQueue(st);
    },
          Severity: Minor
          Found in packages/react-hooks/src/ctx/Queue.tsx and 1 other location - About 40 mins to fix
          packages/react-hooks/src/ctx/Queue.tsx on lines 174..180

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status