Sign upLogin

polkadot-js/apps

View on GitHub
Star
packages/react-params/src/Param/findComponent.ts

Summary

Maintainability
B
6 hrs
Test Coverage

Function findComponent has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

export default function findComponent (registry: Registry, def: TypeDef, overrides: ComponentMap = {}): React.ComponentType<Props> {
  // Explicit/special handling for Account20/32 types where they don't match
  // the actual chain we are connected to
  if (['AccountId20', 'AccountId32'].includes(def.type)) {
    const defType = `AccountId${registry.createType('AccountId').length}`;
Severity: Minor
Found in packages/react-params/src/Param/findComponent.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function fromDef has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

function fromDef ({ displayName, info, lookupName, sub, type }: TypeDef): string {
  if (displayName && SPECIAL_TYPES.includes(displayName)) {
    return displayName;
  } else if (type.endsWith('RuntimeSessionKeys')) {
    return 'RuntimeSessionKeys';
Severity: Minor
Found in packages/react-params/src/Param/findComponent.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function findComponent has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function findComponent (registry: Registry, def: TypeDef, overrides: ComponentMap = {}): React.ComponentType<Props> {
  // Explicit/special handling for Account20/32 types where they don't match
  // the actual chain we are connected to
  if (['AccountId20', 'AccountId32'].includes(def.type)) {
    const defType = `AccountId${registry.createType('AccountId').length}`;
Severity: Minor
Found in packages/react-params/src/Param/findComponent.ts - About 1 hr to fix

    Avoid too many return statements within this function.
    Open

      return Component || Unknown;
    Severity: Major
    Found in packages/react-params/src/Param/findComponent.ts - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status