polkadot-js/client

View on GitHub
packages/client-p2p/src/peer/index.ts

Summary

Maintainability
B
6 hrs
Test Coverage

Function _receive has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  private _receive (connection: LibP2pConnection, connId: number): boolean {
    let data: Uint8Array | null = null;
    let received: number;
    let remaining = 0;

Severity: Minor
Found in packages/client-p2p/src/peer/index.ts - About 1 hr to fix

    Function ping has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      private async ping (): Promise<boolean> {
        if (!this.node || !this.isActive()) {
          this.startPing();
          return false;
        }
    Severity: Minor
    Found in packages/client-p2p/src/peer/index.ts - About 1 hr to fix

      Function addConnection has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        public addConnection (connection: LibP2pConnection, isWritable: boolean): number {
          const connId = this.nextConnId++;
          const pushable = isWritable
            ? PullPushable((error): void => {
              l.debug((): any[] => [`${this.shortId} pushable error`, error]);
      Severity: Minor
      Found in packages/client-p2p/src/peer/index.ts - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                (error): boolean => {
                  l.debug((): any[] => [`${this.shortId} receive error`, error]);
        
                  this.clearConnection(connId);
        
        
        Severity: Minor
        Found in packages/client-p2p/src/peer/index.ts and 1 other location - About 55 mins to fix
        packages/client-p2p/src/peer/index.ts on lines 250..256

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            } catch (error) {
              l.debug((): any[] => [`${this.shortId} receive error`, error]);
        
              this.clearConnection(connId);
        
        
        Severity: Minor
        Found in packages/client-p2p/src/peer/index.ts and 1 other location - About 55 mins to fix
        packages/client-p2p/src/peer/index.ts on lines 242..248

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status