polkadot-js/common

View on GitHub

Showing 87 of 304 total issues

Function isUtf8 has a Cognitive Complexity of 127 (exceeds 5 allowed). Consider refactoring.
Open

export function isUtf8 (value?: number[] | Uint8Array | string | null): boolean {
  if (!value) {
    return isString(value);
  }

Severity: Minor
Found in packages/util/src/is/utf8.ts - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _formatBalance has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

function _formatBalance <ExtToBn extends ToBn> (input?: number | string | BN | bigint | ExtToBn, { decimals = defaultDecimals, forceUnit, locale = 'en', withAll = false, withSi = true, withSiFull = false, withUnit = true, withZero = true }: Options = {}): string {
  // we only work with string inputs here - convert anything
  // into the string-only value
  let text = bnToBn(input).toString();

Severity: Minor
Found in packages/util/src/format/formatBalance.ts - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function isUtf8 has 99 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function isUtf8 (value?: number[] | Uint8Array | string | null): boolean {
  if (!value) {
    return isString(value);
  }

Severity: Major
Found in packages/util/src/is/utf8.ts - About 3 hrs to fix

    Function crypto_onetimeauth has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

    function crypto_onetimeauth (out: Uint8Array, outpos: number, m: Uint8Array, mpos: number, n: number, k: Uint8Array): number {
      let i, j, u;
      const x = new Uint32Array(17), r = new Uint32Array(17), h = new Uint32Array(17), c = new Uint32Array(17), g = new Uint32Array(17);
      for (j = 0; j < 17; j++) r[j]=h[j]=0;
      for (j = 0; j < 16; j++) r[j]=k[j];
    Severity: Minor
    Found in packages/util-crypto/src/nacl/tweetnacl.ts - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function createPair has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

    export function createPair ({ toSS58, type }: Setup, { publicKey, secretKey }: PairInfo, meta: KeyringPair$Meta = {}, encoded: Uint8Array | null = null, encTypes?: EncryptedJsonEncoding[]): KeyringPair {
      const decodePkcs8 = (passphrase?: string, userEncoded?: Uint8Array | null): void => {
        const decoded = decodePair(passphrase, userEncoded || encoded, encTypes);
    
        if (decoded.secretKey.length === 64) {
    Severity: Minor
    Found in packages/keyring/src/pair/index.ts - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function core has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

    function core (out: Uint8Array, inp: Uint8Array, k: Uint8Array, c: Uint8Array, h: boolean): void {
      const w = new Uint32Array(16), x = new Uint32Array(16), y = new Uint32Array(16), t = new Uint32Array(4);
      let i, j, m;
    
      for (i = 0; i < 4; i++) {
    Severity: Minor
    Found in packages/util-crypto/src/nacl/tweetnacl.ts - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function bnToBn has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

    export function bnToBn <ExtToBn extends ToBigInt | ToBn> (value?: ExtToBn | BN | bigint | string | number | null): BN {
      return value
        ? BN.isBN(value)
          ? value
          : isHex(value)
    Severity: Minor
    Found in packages/util/src/bn/toBn.ts - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function nToBigInt has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

    export function nToBigInt <ExtToBn extends ToBigInt | ToBn> (value?: ExtToBn | BN | bigint | string | number | null): bigint {
      return typeof value === 'bigint'
        ? value
        : !value
          ? BigInt(0)
    Severity: Minor
    Found in packages/util/src/bi/toBigInt.ts - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function crypto_stream_salsa20_xor has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

    function crypto_stream_salsa20_xor (c: Uint8Array, cpos: number, m: Uint8Array | null, mpos: number, b: number, n: Uint8Array, k: Uint8Array): number {
      const z = new Uint8Array(16), x = new Uint8Array(64);
      let u, i;
      if (!b) return 0;
      for (i = 0; i < 16; i++) z[i] = 0;
    Severity: Minor
    Found in packages/util-crypto/src/nacl/tweetnacl.ts - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function u8aToBigInt has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

    export function u8aToBigInt (value: Uint8Array, { isLe = true, isNegative = false }: ToBnOptions = {}): bigint {
      // slice + reverse is expensive, however SCALE is LE by default so this is the path
      // we are most interested in (the BE is added for the sake of being comprehensive)
      if (!isLe) {
        value = value.slice().reverse();
    Severity: Minor
    Found in packages/util/src/u8a/toBigInt.ts - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function crypto_onetimeauth has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function crypto_onetimeauth (out: Uint8Array, outpos: number, m: Uint8Array, mpos: number, n: number, k: Uint8Array): number {
      let i, j, u;
      const x = new Uint32Array(17), r = new Uint32Array(17), h = new Uint32Array(17), c = new Uint32Array(17), g = new Uint32Array(17);
      for (j = 0; j < 17; j++) r[j]=h[j]=0;
      for (j = 0; j < 16; j++) r[j]=k[j];
    Severity: Minor
    Found in packages/util-crypto/src/nacl/tweetnacl.ts - About 1 hr to fix

      Function core has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function core (out: Uint8Array, inp: Uint8Array, k: Uint8Array, c: Uint8Array, h: boolean): void {
        const w = new Uint32Array(16), x = new Uint32Array(16), y = new Uint32Array(16), t = new Uint32Array(4);
        let i, j, m;
      
        for (i = 0; i < 4; i++) {
      Severity: Minor
      Found in packages/util-crypto/src/nacl/tweetnacl.ts - About 1 hr to fix

        Function objectSpread has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

        export function objectSpread <T extends object> (dest: object, ...sources: (object | undefined | null)[]): T {
          for (let i = 0, count = sources.length; i < count; i++) {
            const src = sources[i];
        
            if (src) {
        Severity: Minor
        Found in packages/util/src/object/spread.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function u8aEq has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

        export function u8aEq (a: string | Uint8Array, b: string | Uint8Array): boolean {
          const u8aa = u8aToU8a(a);
          const u8ab = u8aToU8a(b);
        
          if (u8aa.length === u8ab.length) {
        Severity: Minor
        Found in packages/util/src/u8a/eq.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function init has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function init (seed: bigint, input: Uint8Array): State {
          const state = {
            seed,
            u8a: new Uint8Array(32),
            u8asize: 0,
        Severity: Minor
        Found in packages/util-crypto/src/xxhash/xxhash64.ts - About 1 hr to fix

          Function u8aCmp has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

          export function u8aCmp (a: string | Uint8Array, b: string | Uint8Array): number {
            const u8aa = u8aToU8a(a);
            const u8ab = u8aToU8a(b);
            let i = 0;
          
          
          Severity: Minor
          Found in packages/util/src/u8a/cmp.ts - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function xxhash64 has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export function xxhash64 (input: Uint8Array, initSeed: bigint | number): Uint8Array {
            const { seed, u8a, u8asize, v1, v2, v3, v4 } = init(BigInt(initSeed), input);
            let p = 0;
            let h64 = U64 & (BigInt(input.length) + (
              input.length >= 32
          Severity: Minor
          Found in packages/util-crypto/src/xxhash/xxhash64.ts - About 1 hr to fix

            Function mnemonicToEntropy has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            export function mnemonicToEntropy (mnemonic: string, wordlist: string[] = DEFAULT_WORDLIST): Uint8Array {
              const words = normalize(mnemonic).split(' ');
            
              if (words.length % 3 !== 0) {
                throw new Error(INVALID_MNEMONIC);
            Severity: Minor
            Found in packages/util-crypto/src/mnemonic/bip39.ts - About 1 hr to fix

              Function crypto_stream_xor has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              function crypto_stream_xor (c: Uint8Array, cpos: number, m: Uint8Array | null, mpos: number, d: number, n: Uint8Array, k: Uint8Array): number {
              Severity: Major
              Found in packages/util-crypto/src/nacl/tweetnacl.ts - About 50 mins to fix

                Function crypto_stream_salsa20_xor has 7 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                function crypto_stream_salsa20_xor (c: Uint8Array, cpos: number, m: Uint8Array | null, mpos: number, b: number, n: Uint8Array, k: Uint8Array): number {
                Severity: Major
                Found in packages/util-crypto/src/nacl/tweetnacl.ts - About 50 mins to fix
                  Severity
                  Category
                  Status
                  Source
                  Language