Sign upLogin

polkadot-js/common

View on GitHub
Star

Showing 304 of 304 total issues

Function nToU8a has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

export function nToU8a <ExtToBn extends ToBn | ToBigInt> (value?: ExtToBn | BN | bigint | number | null, { bitLength = -1, isLe = true, isNegative = false }: NumberOptions = {}): Uint8Array {
  const valueBi = nToBigInt(value);

  if (valueBi === _0n) {
    return bitLength === -1
Severity: Minor
Found in packages/util/src/bi/toU8a.ts - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function hdEthereum has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

export function hdEthereum (seed: Uint8Array, path = ''): Keypair {
  const I = hmacShaAsU8a(MASTER_SECRET, seed, 512);
  let hd = createCoded(I.slice(0, 32), I.slice(32));

  if (!path || path === 'm' || path === 'M' || path === "m'" || path === "M'") {
Severity: Minor
Found in packages/util-crypto/src/hd/ethereum/index.ts - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export function getRandomValues <T extends Uint8Array> (arr: T): T {
  return crypto.getRandomValues(arr);
}
Severity: Minor
Found in packages/x-randomvalues/src/browser.ts and 1 other location - About 35 mins to fix
packages/x-randomvalues/src/node.ts on lines 15..17

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  beforeEach(async (): Promise<void> => {
    const node = await import('./node.js');

    TE = node.TextEncoder;
  });
Severity: Minor
Found in packages/x-textencoder/src/node.spec.ts and 1 other location - About 35 mins to fix
packages/x-textdecoder/src/node.spec.ts on lines 14..18

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export function getRandomValues <T extends Uint8Array> (output: T): T {
  return crypto.getRandomValues(output);
}
Severity: Minor
Found in packages/x-randomvalues/src/node.ts and 1 other location - About 35 mins to fix
packages/x-randomvalues/src/browser.ts on lines 12..14

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  beforeEach(async (): Promise<void> => {
    const node = await import('./node.js');

    TD = node.TextDecoder;
  });
Severity: Minor
Found in packages/x-textdecoder/src/node.spec.ts and 1 other location - About 35 mins to fix
packages/x-textencoder/src/node.spec.ts on lines 14..18

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

  it('correctly extracts the info from a 2-byte-prefix address (69)', (): void => {
    expect(
      checkAddressChecksum(base58Decode('cnVvyMzRdqjwejTFuByQQ4w2yu78V2hpFixjHQz5zr6NSYsxA'))
    ).toEqual([true, 34, 2, 69]);
  });
Severity: Major
Found in packages/util-crypto/src/address/checksum.spec.ts and 5 other locations - About 30 mins to fix
packages/util-crypto/src/address/checksum.spec.ts on lines 10..14
packages/util-crypto/src/address/checksum.spec.ts on lines 16..20
packages/util-crypto/src/address/checksum.spec.ts on lines 28..32
packages/util-crypto/src/address/checksum.spec.ts on lines 34..38
packages/util-crypto/src/address/checksum.spec.ts on lines 40..44

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

        return false;
Severity: Major
Found in packages/util/src/is/utf8.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

              return false;
    Severity: Major
    Found in packages/util/src/is/utf8.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                return false;
      Severity: Major
      Found in packages/util/src/is/utf8.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return false;
        Severity: Major
        Found in packages/util/src/is/utf8.ts - About 30 mins to fix

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

            it('correctly extracts the info from a 2-byte-prefix address (255)', (): void => {
    expect(
      checkAddressChecksum(base58Decode('yGHU8YKprxHbHdEv7oUK4rzMZXtsdhcXVG2CAMyC9WhzhjH2k'))
    ).toEqual([true, 34, 2, 255]);
  });
          Severity: Major
          Found in packages/util-crypto/src/address/checksum.spec.ts and 5 other locations - About 30 mins to fix
          packages/util-crypto/src/address/checksum.spec.ts on lines 10..14
          packages/util-crypto/src/address/checksum.spec.ts on lines 16..20
          packages/util-crypto/src/address/checksum.spec.ts on lines 22..26
          packages/util-crypto/src/address/checksum.spec.ts on lines 28..32
          packages/util-crypto/src/address/checksum.spec.ts on lines 40..44

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Avoid too many return statements within this function.
          Open

                    return false;
          Severity: Major
          Found in packages/util/src/is/utf8.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                      return false;
            Severity: Major
            Found in packages/util/src/is/utf8.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                        return false;
              Severity: Major
              Found in packages/util/src/is/utf8.ts - About 30 mins to fix

                Similar blocks of code found in 6 locations. Consider refactoring.
                Open

                  it('correctly extracts the info from a 2-byte-prefix address (66)', (): void => {
    expect(
      checkAddressChecksum(base58Decode('cTGShekJ1L1UKFZR9xmv9UTJod7vqjFAPo4sDhXih2c3y1yLS'))
    ).toEqual([true, 34, 2, 66]);
  });
                Severity: Major
                Found in packages/util-crypto/src/address/checksum.spec.ts and 5 other locations - About 30 mins to fix
                packages/util-crypto/src/address/checksum.spec.ts on lines 10..14
                packages/util-crypto/src/address/checksum.spec.ts on lines 22..26
                packages/util-crypto/src/address/checksum.spec.ts on lines 28..32
                packages/util-crypto/src/address/checksum.spec.ts on lines 34..38
                packages/util-crypto/src/address/checksum.spec.ts on lines 40..44

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 45.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Avoid too many return statements within this function.
                Open

                        return false;
                Severity: Major
                Found in packages/util/src/is/utf8.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                            return false;
                  Severity: Major
                  Found in packages/util/src/is/utf8.ts - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return false;
                    Severity: Major
                    Found in packages/util/src/is/utf8.ts - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                return false;
                      Severity: Major
                      Found in packages/util/src/is/utf8.ts - About 30 mins to fix
                        Severity
                        Category
                        Status
                        Source
                        Language