Sign upLogin

polkadot-js/common

View on GitHub
Star
packages/util-crypto/src/signature/verify.spec.ts

Summary

Maintainability
D
1 day
Test Coverage

Similar blocks of code found in 11 locations. Consider refactoring.
Open

    it('verifies an ed25519 signature', (): void => {
      expect(signatureVerify(MESSAGE, MUL_ED, ADDR_ED)).toEqual({
        crypto: 'ed25519',
        isValid: true,
        isWrapped: false,
Severity: Major
Found in packages/util-crypto/src/signature/verify.spec.ts and 10 other locations - About 1 hr to fix
packages/util-crypto/src/signature/verify.spec.ts on lines 40..47
packages/util-crypto/src/signature/verify.spec.ts on lines 49..56
packages/util-crypto/src/signature/verify.spec.ts on lines 58..65
packages/util-crypto/src/signature/verify.spec.ts on lines 82..89
packages/util-crypto/src/signature/verify.spec.ts on lines 91..98
packages/util-crypto/src/signature/verify.spec.ts on lines 109..116
packages/util-crypto/src/signature/verify.spec.ts on lines 127..134
packages/util-crypto/src/signature/verify.spec.ts on lines 147..154
packages/util-crypto/src/signature/verify.spec.ts on lines 156..163
packages/util-crypto/src/signature/verify.spec.ts on lines 165..172

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

    it('verifies an sr25519 signature', (): void => {
      expect(signatureVerify(MESSAGE, SIG_SR, ADDR_SR)).toEqual({
        crypto: 'sr25519',
        isValid: true,
        isWrapped: false,
Severity: Major
Found in packages/util-crypto/src/signature/verify.spec.ts and 10 other locations - About 1 hr to fix
packages/util-crypto/src/signature/verify.spec.ts on lines 40..47
packages/util-crypto/src/signature/verify.spec.ts on lines 49..56
packages/util-crypto/src/signature/verify.spec.ts on lines 58..65
packages/util-crypto/src/signature/verify.spec.ts on lines 82..89
packages/util-crypto/src/signature/verify.spec.ts on lines 109..116
packages/util-crypto/src/signature/verify.spec.ts on lines 127..134
packages/util-crypto/src/signature/verify.spec.ts on lines 138..145
packages/util-crypto/src/signature/verify.spec.ts on lines 147..154
packages/util-crypto/src/signature/verify.spec.ts on lines 156..163
packages/util-crypto/src/signature/verify.spec.ts on lines 165..172

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

    it('verifies an ethereum signature', (): void => {
      expect(signatureVerify(MESSAGE, MUL_ET, ADDR_ET)).toEqual({
        crypto: 'ethereum',
        isValid: true,
        isWrapped: false,
Severity: Major
Found in packages/util-crypto/src/signature/verify.spec.ts and 10 other locations - About 1 hr to fix
packages/util-crypto/src/signature/verify.spec.ts on lines 40..47
packages/util-crypto/src/signature/verify.spec.ts on lines 49..56
packages/util-crypto/src/signature/verify.spec.ts on lines 58..65
packages/util-crypto/src/signature/verify.spec.ts on lines 82..89
packages/util-crypto/src/signature/verify.spec.ts on lines 91..98
packages/util-crypto/src/signature/verify.spec.ts on lines 109..116
packages/util-crypto/src/signature/verify.spec.ts on lines 127..134
packages/util-crypto/src/signature/verify.spec.ts on lines 138..145
packages/util-crypto/src/signature/verify.spec.ts on lines 147..154
packages/util-crypto/src/signature/verify.spec.ts on lines 165..172

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

    it('fails on an invalid signature', (): void => {
      expect(signatureVerify(MESSAGE, SIG_SR, ADDR_ED)).toEqual({
        crypto: 'none',
        isValid: false,
        isWrapped: false,
Severity: Major
Found in packages/util-crypto/src/signature/verify.spec.ts and 10 other locations - About 1 hr to fix
packages/util-crypto/src/signature/verify.spec.ts on lines 40..47
packages/util-crypto/src/signature/verify.spec.ts on lines 49..56
packages/util-crypto/src/signature/verify.spec.ts on lines 58..65
packages/util-crypto/src/signature/verify.spec.ts on lines 82..89
packages/util-crypto/src/signature/verify.spec.ts on lines 91..98
packages/util-crypto/src/signature/verify.spec.ts on lines 109..116
packages/util-crypto/src/signature/verify.spec.ts on lines 138..145
packages/util-crypto/src/signature/verify.spec.ts on lines 147..154
packages/util-crypto/src/signature/verify.spec.ts on lines 156..163
packages/util-crypto/src/signature/verify.spec.ts on lines 165..172

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

    it('verifies an ed25519 signature', (): void => {
      expect(signatureVerify(MESSAGE, SIG_ED, ADDR_ED)).toEqual({
        crypto: 'ed25519',
        isValid: true,
        isWrapped: false,
Severity: Major
Found in packages/util-crypto/src/signature/verify.spec.ts and 10 other locations - About 1 hr to fix
packages/util-crypto/src/signature/verify.spec.ts on lines 49..56
packages/util-crypto/src/signature/verify.spec.ts on lines 58..65
packages/util-crypto/src/signature/verify.spec.ts on lines 82..89
packages/util-crypto/src/signature/verify.spec.ts on lines 91..98
packages/util-crypto/src/signature/verify.spec.ts on lines 109..116
packages/util-crypto/src/signature/verify.spec.ts on lines 127..134
packages/util-crypto/src/signature/verify.spec.ts on lines 138..145
packages/util-crypto/src/signature/verify.spec.ts on lines 147..154
packages/util-crypto/src/signature/verify.spec.ts on lines 156..163
packages/util-crypto/src/signature/verify.spec.ts on lines 165..172

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

    it('verifies an ecdsa signature', (): void => {
      expect(signatureVerify(MESSAGE, SIG_EC, ADDR_EC)).toEqual({
        crypto: 'ecdsa',
        isValid: true,
        isWrapped: false,
Severity: Major
Found in packages/util-crypto/src/signature/verify.spec.ts and 10 other locations - About 1 hr to fix
packages/util-crypto/src/signature/verify.spec.ts on lines 40..47
packages/util-crypto/src/signature/verify.spec.ts on lines 58..65
packages/util-crypto/src/signature/verify.spec.ts on lines 82..89
packages/util-crypto/src/signature/verify.spec.ts on lines 91..98
packages/util-crypto/src/signature/verify.spec.ts on lines 109..116
packages/util-crypto/src/signature/verify.spec.ts on lines 127..134
packages/util-crypto/src/signature/verify.spec.ts on lines 138..145
packages/util-crypto/src/signature/verify.spec.ts on lines 147..154
packages/util-crypto/src/signature/verify.spec.ts on lines 156..163
packages/util-crypto/src/signature/verify.spec.ts on lines 165..172

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

    it('verifies an sr25519 signature', (): void => {
      expect(signatureVerify(MESSAGE, MUL_SR, ADDR_SR)).toEqual({
        crypto: 'sr25519',
        isValid: true,
        isWrapped: false,
Severity: Major
Found in packages/util-crypto/src/signature/verify.spec.ts and 10 other locations - About 1 hr to fix
packages/util-crypto/src/signature/verify.spec.ts on lines 40..47
packages/util-crypto/src/signature/verify.spec.ts on lines 49..56
packages/util-crypto/src/signature/verify.spec.ts on lines 58..65
packages/util-crypto/src/signature/verify.spec.ts on lines 82..89
packages/util-crypto/src/signature/verify.spec.ts on lines 91..98
packages/util-crypto/src/signature/verify.spec.ts on lines 109..116
packages/util-crypto/src/signature/verify.spec.ts on lines 127..134
packages/util-crypto/src/signature/verify.spec.ts on lines 138..145
packages/util-crypto/src/signature/verify.spec.ts on lines 147..154
packages/util-crypto/src/signature/verify.spec.ts on lines 156..163

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

    it('verifies an ethereum signature', (): void => {
      expect(signatureVerify(MESSAGE, SIG_ET, ADDR_ET)).toEqual({
        crypto: 'ethereum',
        isValid: true,
        isWrapped: false,
Severity: Major
Found in packages/util-crypto/src/signature/verify.spec.ts and 10 other locations - About 1 hr to fix
packages/util-crypto/src/signature/verify.spec.ts on lines 40..47
packages/util-crypto/src/signature/verify.spec.ts on lines 49..56
packages/util-crypto/src/signature/verify.spec.ts on lines 82..89
packages/util-crypto/src/signature/verify.spec.ts on lines 91..98
packages/util-crypto/src/signature/verify.spec.ts on lines 109..116
packages/util-crypto/src/signature/verify.spec.ts on lines 127..134
packages/util-crypto/src/signature/verify.spec.ts on lines 138..145
packages/util-crypto/src/signature/verify.spec.ts on lines 147..154
packages/util-crypto/src/signature/verify.spec.ts on lines 156..163
packages/util-crypto/src/signature/verify.spec.ts on lines 165..172

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

    it('fails on invalid ethereum signature', (): void => {
      expect(signatureVerify(MESSAGE, SIG_EC, ADDR_ET)).toEqual({
        crypto: 'none',
        isValid: false,
        isWrapped: false,
Severity: Major
Found in packages/util-crypto/src/signature/verify.spec.ts and 10 other locations - About 1 hr to fix
packages/util-crypto/src/signature/verify.spec.ts on lines 40..47
packages/util-crypto/src/signature/verify.spec.ts on lines 49..56
packages/util-crypto/src/signature/verify.spec.ts on lines 58..65
packages/util-crypto/src/signature/verify.spec.ts on lines 91..98
packages/util-crypto/src/signature/verify.spec.ts on lines 109..116
packages/util-crypto/src/signature/verify.spec.ts on lines 127..134
packages/util-crypto/src/signature/verify.spec.ts on lines 138..145
packages/util-crypto/src/signature/verify.spec.ts on lines 147..154
packages/util-crypto/src/signature/verify.spec.ts on lines 156..163
packages/util-crypto/src/signature/verify.spec.ts on lines 165..172

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

    it('verifies an sr25519 signature (without msg wrapper, with wrapped sig)', (): void => {
      expect(signatureVerify(MESSAGE, SIG_SR_WRAP, ADDR_SR_WRAP)).toEqual({
        crypto: 'sr25519',
        isValid: true,
        isWrapped: false,
Severity: Major
Found in packages/util-crypto/src/signature/verify.spec.ts and 10 other locations - About 1 hr to fix
packages/util-crypto/src/signature/verify.spec.ts on lines 40..47
packages/util-crypto/src/signature/verify.spec.ts on lines 49..56
packages/util-crypto/src/signature/verify.spec.ts on lines 58..65
packages/util-crypto/src/signature/verify.spec.ts on lines 82..89
packages/util-crypto/src/signature/verify.spec.ts on lines 91..98
packages/util-crypto/src/signature/verify.spec.ts on lines 127..134
packages/util-crypto/src/signature/verify.spec.ts on lines 138..145
packages/util-crypto/src/signature/verify.spec.ts on lines 147..154
packages/util-crypto/src/signature/verify.spec.ts on lines 156..163
packages/util-crypto/src/signature/verify.spec.ts on lines 165..172

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

    it('verifies an ecdsa signature', (): void => {
      expect(signatureVerify(MESSAGE, MUL_EC, ADDR_EC)).toEqual({
        crypto: 'ecdsa',
        isValid: true,
        isWrapped: false,
Severity: Major
Found in packages/util-crypto/src/signature/verify.spec.ts and 10 other locations - About 1 hr to fix
packages/util-crypto/src/signature/verify.spec.ts on lines 40..47
packages/util-crypto/src/signature/verify.spec.ts on lines 49..56
packages/util-crypto/src/signature/verify.spec.ts on lines 58..65
packages/util-crypto/src/signature/verify.spec.ts on lines 82..89
packages/util-crypto/src/signature/verify.spec.ts on lines 91..98
packages/util-crypto/src/signature/verify.spec.ts on lines 109..116
packages/util-crypto/src/signature/verify.spec.ts on lines 127..134
packages/util-crypto/src/signature/verify.spec.ts on lines 138..145
packages/util-crypto/src/signature/verify.spec.ts on lines 156..163
packages/util-crypto/src/signature/verify.spec.ts on lines 165..172

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status