Sign upLogin

polkadot-js/extension

View on GitHub
Star
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx

Summary

Maintainability
D
1 day
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('first password changes, then second changes too - button is enabled', async () => {
      await type(wrapper.find('input[type="password"]').first(), 'abcdef');
      await type(wrapper.find('input[type="password"]').last(), 'abcdef');
      expect(wrapper.find('[data-button-action="add new root"] button').prop('disabled')).toBe(false);
    });
Severity: Major
Found in packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx and 1 other location - About 2 hrs to fix
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 182..186

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('second password changes, then first changes too - button is enabled', async () => {
      await type(wrapper.find('input[type="password"]').last(), 'abcdef');
      await type(wrapper.find('input[type="password"]').first(), 'abcdef');
      expect(wrapper.find('[data-button-action="add new root"] button').prop('disabled')).toBe(false);
    });
Severity: Major
Found in packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx and 1 other location - About 2 hrs to fix
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 176..180

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

const type = async (input: ReactWrapper, value: string): Promise<void> => {
  input.simulate('change', { target: { value } });
  await act(flushAllPromises);
  wrapper.update();
};
Severity: Major
Found in packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx and 3 other locations - About 2 hrs to fix
packages/extension-ui/src/Popup/CreateAccount/CreateAccount.spec.tsx on lines 52..56
packages/extension-ui/src/Popup/Derive/Derive.spec.tsx on lines 86..90
packages/extension-ui/src/Popup/ImportSeed/ImportSeed.spec.tsx on lines 65..69

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 77.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

const password = (password: string) => (): Promise<void> => type(wrapper.find('input[type="password"]').first(), password);
Severity: Major
Found in packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx and 6 other locations - About 40 mins to fix
packages/extension-ui/src/Popup/CreateAccount/CreateAccount.spec.tsx on lines 59..59
packages/extension-ui/src/Popup/CreateAccount/CreateAccount.spec.tsx on lines 60..60
packages/extension-ui/src/Popup/Derive/Derive.spec.tsx on lines 93..93
packages/extension-ui/src/Popup/Derive/Derive.spec.tsx on lines 94..94
packages/extension-ui/src/Popup/ImportSeed/ImportSeed.spec.tsx on lines 72..72
packages/extension-ui/src/Popup/ImportSeed/ImportSeed.spec.tsx on lines 73..73

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    expect(wrapper.find(InputWithLabel).find('[data-input-repeat-password]').find(Input).prop('withError')).toBe(false);
Severity: Major
Found in packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx and 5 other locations - About 35 mins to fix
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 90..90
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 95..95
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 105..105
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 130..130
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 140..140

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    expect(wrapper.find(InputWithLabel).find('[data-input-name]').find(Input).prop('withError')).toBe(true);
Severity: Major
Found in packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx and 5 other locations - About 35 mins to fix
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 90..90
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 105..105
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 130..130
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 140..140
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 147..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    expect(wrapper.find(InputWithLabel).find('[data-input-name]').find(Input).prop('withError')).toBe(true);
Severity: Major
Found in packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx and 5 other locations - About 35 mins to fix
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 90..90
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 95..95
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 130..130
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 140..140
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 147..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    expect(wrapper.find(InputWithLabel).find('[data-input-name]').find(Input).prop('withError')).toBe(false);
Severity: Major
Found in packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx and 5 other locations - About 35 mins to fix
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 95..95
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 105..105
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 130..130
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 140..140
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 147..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    expect(wrapper.find(InputWithLabel).find('[data-input-repeat-password]').find(Input).prop('withError')).toBe(true);
Severity: Major
Found in packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx and 5 other locations - About 35 mins to fix
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 90..90
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 95..95
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 105..105
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 130..130
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 147..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

    expect(wrapper.find(InputWithLabel).find('[data-input-password]').find(Input).prop('withError')).toBe(true);
Severity: Major
Found in packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx and 5 other locations - About 35 mins to fix
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 90..90
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 95..95
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 105..105
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 140..140
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 147..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

const enterName = (name: string): Promise<void> => type(wrapper.find('input').first(), name);
Severity: Major
Found in packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx and 3 other locations - About 30 mins to fix
packages/extension-ui/src/Popup/CreateAccount/CreateAccount.spec.tsx on lines 58..58
packages/extension-ui/src/Popup/Derive/Derive.spec.tsx on lines 92..92
packages/extension-ui/src/Popup/ImportSeed/ImportSeed.spec.tsx on lines 71..71

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

      await enterName(account.name).then(password(account.password)).then(repeat(account.password));
Severity: Major
Found in packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx and 3 other locations - About 30 mins to fix
packages/extension-ui/src/Popup/Derive/Derive.spec.tsx on lines 293..293
packages/extension-ui/src/Popup/ImportSeed/ImportSeed.spec.tsx on lines 195..195
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 152..152

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    await enterName(account.name).then(password(account.password)).then(repeat(account.password));
Severity: Major
Found in packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx and 3 other locations - About 30 mins to fix
packages/extension-ui/src/Popup/Derive/Derive.spec.tsx on lines 293..293
packages/extension-ui/src/Popup/ImportSeed/ImportSeed.spec.tsx on lines 195..195
packages/extension-ui/src/components/AccountNamePasswordCreation.spec.tsx on lines 161..161

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status